-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-lib: Enable tests #34381
airbyte-lib: Enable tests #34381
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@flash1293, Thanks for creating. Just FYI, I added a dummy commit to trigger CI and hopefully repro the issue. 👍 |
…/airbyte into flash1293/airbyte-lib-ci-tests
@alafanechere I did finish eventually - seems like what works on my local airbyte-ci doesn't work on Github CI... I would appreciate a look from your side how to reach the postgres docker container from within the test container. I guess using dagger is one option. I used a "tunnel" to reach the container in the airbyte-ci integration tests as well: https://github.com/airbytehq/airbyte/pull/34111/files#diff-dbf7615b254775dc9fde6cd44e9b39cecdb7309661683244bc7eecac584a2870R74 However looking at how CAT is using it, it seems to pull in a lot of complexity to get it set up, I hope we can avoid that. |
@alafanechere On second thought, let me spend half an hour on it on Monday, maybe it's not as complex as I think |
920c918
to
8624dc3
Compare
8624dc3
to
8c3fbda
Compare
…/airbyte into flash1293/airbyte-lib-ci-tests
This reverts commit e08175d.
…/airbyte into flash1293/airbyte-lib-ci-tests
The tests are running correctly in CI now.
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io> Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io> Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Enables test for airbyte-lib (currently failing because the step gets stuck)