-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: run poetry check
before poetry install
on poetry package install
#35204
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
b31b4e5
to
aa157aa
Compare
@@ -45,7 +45,7 @@ async def _create_builder_container(self, base_container: Container) -> Containe | |||
Returns: | |||
Container: The builder container, with installed dependencies. | |||
""" | |||
ONLY_BUILD_FILES = ["pyproject.toml", "poetry.lock", "poetry.toml", "setup.py", "requirements.txt"] | |||
ONLY_BUILD_FILES = ["pyproject.toml", "poetry.lock", "poetry.toml", "setup.py", "requirements.txt", "README.md"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the README.md file is declared in pyproject.toml the poetry check command checks if it's available. It's why we need it at build time.
aa157aa
to
8a3b485
Compare
What
Closes #35205
On connector build we want to make sure the
poetry.lock
andpyproject.toml
files are consistent in terms of dependency declarationHow
Run
poetry check
beforepoetry install