airbyte-ci/metadata-lib: make dockerhub credentials optional #37787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/05-03-airbyte-ci/metadata-lib_make_dockerhub_credentials_optional
branch
2 times, most recently
from
9f1ce07
to
450205d
Compare
alafanechere
force-pushed
the
augustin/05-03-airbyte-ci/metadata-lib_make_dockerhub_credentials_optional
branch
from
450205d
to
4e70382
Compare
bnchrch
approved these changes
May 3, 2024
| @@ -40,8 +40,14 @@ def is_image_on_docker_hub(image_name: str, version: str, digest: Optional[str] | |||
| bool: True if the image and version exists on Docker Hub, False otherwise. | |||
| """ | |||
|
|
|||
| token = get_docker_hub_auth_token() | |||
| headers = {"Authorization": f"JWT {token}"} | |||
| if "DOCKER_HUB_USERNAME" not in os.environ or "DOCKER_HUB_PASSWORD" not in os.environ: | |||
alafanechere
force-pushed
the
augustin/05-03-airbyte-ci/metadata-lib_make_dockerhub_credentials_optional
branch
from
4e70382
to
487e98c
Compare
alafanechere
force-pushed
the
augustin/05-03-airbyte-ci/metadata-lib_make_dockerhub_credentials_optional
branch
from
487e98c
to
3b0774d
Compare
alafanechere
deleted the
augustin/05-03-airbyte-ci/metadata-lib_make_dockerhub_credentials_optional
branch
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We required dockerhub credentials to run metadata validation because it checks if the base image declared is available in DockerHub with DockerHub API.
DockerHub API is public but rate limited so using credentials helps in getting higher rate limit.
It also had a strange behavior which looks now gone: when you called it to check an image existence without the token a 403 was returned instead of a 404 when the image does not exists, but a 200 was always returned when the image exists...
Removing requirement on dockerhub credentials in metadata validation will improve DX when running airbyte-ci locally.