Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI 🧹: clean up workflow naming #37792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alafanechere
Copy link
Contributor

An attempt at making our workflow and job names simpler and more explicit for clearer CI checks on PRs

@alafanechere alafanechere requested a review from a team as a code owner May 3, 2024 11:11
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 11:20am

Copy link
Contributor Author

alafanechere commented May 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/05-03-ci_clean_up_workflow_naming branch 3 times, most recently from d6ce479 to 224715d Compare May 3, 2024 11:19
@alafanechere alafanechere force-pushed the augustin/05-03-ci_clean_up_workflow_naming branch from 224715d to 7ced4fa Compare May 3, 2024 11:19
@alafanechere alafanechere changed the title ci: clean up workflow naming CI 🧹: clean up workflow naming May 3, 2024
@@ -1,4 +1,4 @@
name: Connector Ops CI - Connectors Weekly Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Ill be more attached to this since I added it in the first place 😅

But there was two things I wanted to solve originally

  1. Define which team owned a workflow
  2. Mark which of our workflows were "Business Critical" (e.g. Connector Publish) vs "one off creations" (Label Github issues, terminate zombie build instance, etc)

So Im fine changing these but is there a way to still achieve at least #2?

Unfortuantely we cant use folders

But perhaps we could either place the title slug at the end and try to shorten it
1. Connectors Weekly Tests [Ops CI]
1. Connectors Weekly Tests - Critical Ops CI

Copy link
Contributor Author

@alafanechere alafanechere May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnchrch What do you think about using a critical_ prefix on the workflow file name?
I don't find it useful to show that a workflow is critical in the check name on PR, we know it's critical when it has a REQUIRED state.
I'd find it useful to use the filename prefix so that we can easily identify without subfolder, the critical workflow we're maintaining while not impacting the CI checks readability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@bnchrch bnchrch self-requested a review May 7, 2024 13:32
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alafanechere will this change the sort order of these in GhA? I feel like it's easier to find the one I want when they're grouped together. But not a blocker if you feel that this is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants