[airbyte-ci] Improved PR generation flow and a bugfix #38582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
natikgadzhi
changed the title
girarda
approved these changes
May 22, 2024
| @@ -42,18 +42,23 @@ | |||
| default=False, | |||
| help="Create a pull request.", | |||
| ) | |||
|
|
|||
| @click.option( | |||
| "--no-bump", | |||
There was a problem hiding this comment.
nit: the negative flag is a little confusing. why not --bump?
There was a problem hiding this comment.
I had the same thought, but honestly, good enough for an internal tool for now.
|
One type check failed but given there are 593 of them total and I can't run just one file locally, I'm sorry, I'm merging this so I can easily document how to regen all those PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A batch of changes to
airbyte-cithat @bleonard and I did to push up the poetry + base image migration PRs.These seem to make sense universally, so I'm pushing them up:
up_to_dateuntil asked to.pull_request --bumpTODO
This still needs a version bump to airbyte-ci itself.
Can this PR be safely reverted and rolled back?