JSON configuration persistence 2 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Aug 11, 2020
| import java.util.Set; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class JsonSchemaValidation { |
There was a problem hiding this comment.
this looks like a premature refactor here, but it get immediately used in a PR that i'm about to put up.
There was a problem hiding this comment.
proof: file: dataline-server/src/main/java/io/dataline/server/validation/IntegrationSchemaValidation.java in #42.
cgardens
commented
Aug 11, 2020
| @@ -1,13 +1,28 @@ | |||
| package io.dataline.config.persistence; | |||
|
|
|||
| public enum PersistenceConfigType { | |||
| SOURCE_CONNECTION_CONFIGURATION, | |||
| // workspace | |||
cgardens
force-pushed
the
charles/config_persistence2
branch
from
2f673c7
to
8e55ac6
Compare
|
@michel-tricot @sherifnada @sherifnada - this hard blocking progress on the API. going to merge. feel free to leave comments on this PR and i will incorporate them in future work. |
21 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to feedback on this PR #17 and after fiddling around with what implementing some endpoints looks like, I've made two updates to the configuration persistence: