-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON configuration persistence 2 #39
Conversation
import java.util.Set; | ||
import java.util.stream.Collectors; | ||
|
||
public class JsonSchemaValidation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a premature refactor here, but it get immediately used in a PR that i'm about to put up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proof: file: dataline-server/src/main/java/io/dataline/server/validation/IntegrationSchemaValidation.java in #42.
@@ -1,13 +1,28 @@ | |||
package io.dataline.config.persistence; | |||
|
|||
public enum PersistenceConfigType { | |||
SOURCE_CONNECTION_CONFIGURATION, | |||
// workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2f673c7
to
8e55ac6
Compare
@michel-tricot @sherifnada @sherifnada - this hard blocking progress on the API. going to merge. feel free to leave comments on this PR and i will incorporate them in future work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In response to feedback on this PR #17 and after fiddling around with what implementing some endpoints looks like, I've made two updates to the configuration persistence: