airbyte-ci: make slugify consistent with live test #39457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/06-13-airbyte-ci_make_slugify_consistent_with_live_test
branch
from
1b9af72
to
1400e41
Compare
bazarnov
approved these changes
Jun 13, 2024
alafanechere
deleted the
augustin/06-13-airbyte-ci_make_slugify_consistent_with_live_test
branch
Adorism
pushed a commit
that referenced
this pull request
Jun 13, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In
airbyte-ciwe pass the built target connector container to regression test via a container ID stored in a file.The name of this file is a slugification of the connector image + tag name.
The slugification method used in airbyte-ci and regression test diverged following an abusive code cleanup from my side in #39361
How
Re-use the slugify lib Catherine originally installed.