Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo(source-declarative-manifest): Migrate source-pokeapi #39907

Closed
wants to merge 1 commit into from
Closed

demo(source-declarative-manifest): Migrate source-pokeapi #39907

wants to merge 1 commit into from
+1,463 −0

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Jun 20, 2024 •
edited
Loading

What

Demo of migrating a manifest connector to manifest only

@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:47pm

@bnchrch bnchrch mentioned this pull request Jun 20, 2024
Merged
@bnchrch Graphite App
Copy link
Contributor Author

bnchrch commented Jun 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bnchrch and the rest of your teammates on Graphite Graphite

@bnchrch bnchrch mentioned this pull request Jun 20, 2024
Merged
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 4312a30 to 8b9cff3 Compare June 20, 2024 19:38
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch 3 times, most recently from c68bf40 to f6730f7 Compare June 25, 2024 19:00
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from bd67c9e to 5cbae6b Compare June 26, 2024 00:52
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch 2 times, most recently from c9e246b to 669fb9f Compare June 26, 2024 17:13
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 5cbae6b to cbb57f7 Compare June 26, 2024 18:54
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch 2 times, most recently from 5038131 to a5fb84f Compare June 26, 2024 23:44
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from ac1f121 to 5360c5e Compare June 27, 2024 19:00
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from a5fb84f to 34b9778 Compare June 27, 2024 19:00
@bnchrch bnchrch marked this pull request as ready for review June 27, 2024 21:33
@natikgadzhi natikgadzhi mentioned this pull request Jul 2, 2024
Merged
2 tasks
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 5360c5e to 9c15fef Compare July 8, 2024 15:42
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 34b9778 to f62287b Compare July 8, 2024 15:42
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 9c15fef to 2aef347 Compare July 9, 2024 14:15
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from f62287b to c59517a Compare July 9, 2024 14:15
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 2aef347 to 6665351 Compare July 9, 2024 14:24
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from c59517a to e2da6dc Compare July 9, 2024 14:24
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 6665351 to ca3daf0 Compare July 9, 2024 14:28
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from e2da6dc to f13c036 Compare July 9, 2024 14:28
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from ca3daf0 to d22ea61 Compare July 9, 2024 15:46
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from f13c036 to 4f14af7 Compare July 9, 2024 15:46
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from d22ea61 to 247685c Compare July 9, 2024 19:54
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 4f14af7 to 13cffee Compare July 9, 2024 19:54
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 247685c to fb8df7d Compare July 10, 2024 13:43
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 13cffee to 7bf92f2 Compare July 10, 2024 13:44
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 10, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • coderabbit-ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from fb8df7d to 1984f02 Compare July 10, 2024 22:45
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 7bf92f2 to c33efdb Compare July 10, 2024 22:45
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 1984f02 to 1f472fa Compare July 11, 2024 13:04
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from c33efdb to e86353b Compare July 11, 2024 13:04
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from 1f472fa to bfd0d0f Compare July 11, 2024 13:32
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from e86353b to bbec835 Compare July 11, 2024 13:32
@bnchrch bnchrch force-pushed the 06-20-feat_pipelines_add_manifest_only_build branch from bfd0d0f to 1719f64 Compare July 11, 2024 14:09
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from bbec835 to a712ac4 Compare July 11, 2024 14:10
Base automatically changed from 06-20-feat_pipelines_add_manifest_only_build to master July 11, 2024 14:27
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from a712ac4 to f03f917 Compare July 11, 2024 15:49
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 5fe87f4 to 365a596 Compare July 30, 2024 15:08
@bnchrch bnchrch requested a review from a team as a code owner July 30, 2024 15:08
@bnchrch bnchrch changed the base branch from master to 07-30-feat-cat_add_manifest_support July 30, 2024 15:08
@bnchrch bnchrch mentioned this pull request Jul 30, 2024
Merged
@bnchrch bnchrch force-pushed the 07-30-feat-cat_add_manifest_support branch from 3892ac0 to 853ffd8 Compare July 31, 2024 14:06
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 365a596 to 8080d28 Compare July 31, 2024 14:06
Base automatically changed from 07-30-feat-cat_add_manifest_support to master July 31, 2024 14:31
octavia-squidington-iii pushed a commit to airbytehq/airbyte-platform that referenced this pull request Jul 31, 2024
@bnchrch
feat(connector-builder-contribute): enable spec tests for manifest fi…
99bd19e 
…le (#13330)

## What
Updates our cat test config template to enable manifest spec tests introduced by this PR
airbytehq/airbyte#39907
@bnchrch
demo(source-declarative-manifest): Migrate source-pokeapi
0a8fa07 
Merge branch 'master' into 06-20-demo_source-declarative-manifest_migrate_source-pokeapi

Update test format

Add manifest support
@bnchrch bnchrch force-pushed the 06-20-demo_source-declarative-manifest_migrate_source-pokeapi branch from 8080d28 to 0a8fa07 Compare August 6, 2024 21:47
@bnchrch bnchrch mentioned this pull request Aug 6, 2024
Closed
2 tasks
@octavia-squidington-iv octavia-squidington-iv requested a review from a team August 6, 2024 21:48
@bnchrch bnchrch mentioned this pull request Aug 7, 2024
Closed
2 tasks
@bnchrch bnchrch closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/pokeapi-manifest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnchrch @octavia-squidington-iii