Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix use of GH token #40709

Merged
merged 4 commits into from
Jul 5, 2024
Merged

airbyte-ci: fix use of GH token #40709

merged 4 commits into from
Jul 5, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jul 3, 2024

For the GH token, use with_secret_env_variable.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 5, 2024 0:06am

@clnoll clnoll requested a review from a team as a code owner July 3, 2024 18:54
@clnoll clnoll force-pushed the catherine/fix-token branch 2 times, most recently from 2d121c0 to cb80925 Compare July 3, 2024 19:20
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if I understand this correctly this just fetches the secret in a way that doesn't leave it in dagger logs?

@clnoll
Copy link
Contributor Author

clnoll commented Jul 5, 2024

That's right @natikgadzhi.

@clnoll clnoll changed the title WIP: airbyte-ci: fix use of GH token airbyte-ci: fix use of GH token Jul 5, 2024
@clnoll clnoll merged commit 9daef0f into master Jul 5, 2024
30 checks passed
@clnoll clnoll deleted the catherine/fix-token branch July 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants