🐛 airbyte-ci: allow migrate-to-poetry to accept and ignore additional args #40754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While attempting to migrate the few remaining outliers to poetry, I've been encountering the following error when running the
airbyte-ci migrate-to-poetry
command:It seems the
run_connector_migration_to_poetry_pipeline
function was designed to take only two arguments (context and semaphore), but therun_connectors_pipelines
function was passing additional arguments, leading to theTypeError
.How
Rather than do a full investigation, I made a quick wrapper to accept and ignore any additional args other than those explicitly used by the
run_connector_migration_to_poetry_pipeline
function.I ran the command again with this change and am able to successfully complete the pipeline with a full HTML report at the end.
User Impact
Mostly unblocking myself to run this command so I don't have to do things manually (#lazydev).
Can this PR be safely reverted and rolled back?