Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 airbyte-ci: allow migrate-to-poetry to accept and ignore additional args #40754

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jul 5, 2024

What

While attempting to migrate the few remaining outliers to poetry, I've been encountering the following error when running the airbyte-ci migrate-to-poetry command:

Traceback (most recent call last):
  File "airbyte_ci.py", line 217, in <module>
  File "asyncclick/core.py", line 1205, in __call__
  File "anyio/_core/_eventloop.py", line 68, in run
  File "anyio/_backends/_asyncio.py", line 204, in run
  File "asyncio/runners.py", line 44, in run
  File "asyncio/base_events.py", line 649, in run_until_complete
  File "anyio/_backends/_asyncio.py", line 199, in wrapper
  File "asyncclick/core.py", line 1208, in _main
  File "asyncclick/core.py", line 1120, in main
  File "asyncclick/core.py", line 1739, in invoke
  File "asyncclick/core.py", line 1739, in invoke
  File "dagger_pipeline_command.py", line 48, in invoke
    pipeline_success = await super().invoke(ctx)
  File "asyncclick/core.py", line 1485, in invoke
  File "asyncclick/core.py", line 824, in invoke
  File "pipelines/airbyte_ci/connectors/migrate_to_poetry/commands.py", line 62, in migrate_to_poetry
    await run_connectors_pipelines(
  File "pipelines/airbyte_ci/connectors/pipeline.py", line 113, in run_connectors_pipelines
    tg_connectors.start_soon(
  File "anyio/_backends/_asyncio.py", line 729, in start_soon
  File "anyio/_backends/_asyncio.py", line 705, in _spawn
TypeError: run_connector_migration_to_poetry_pipeline() takes 2 positional arguments but 4 were given

It seems the run_connector_migration_to_poetry_pipeline function was designed to take only two arguments (context and semaphore), but the run_connectors_pipelines function was passing additional arguments, leading to the TypeError.

How

Rather than do a full investigation, I made a quick wrapper to accept and ignore any additional args other than those explicitly used by the run_connector_migration_to_poetry_pipeline function.

I ran the command again with this change and am able to successfully complete the pipeline with a full HTML report at the end.

User Impact

Mostly unblocking myself to run this command so I don't have to do things manually (#lazydev).

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 5, 2024 9:15pm

@ChristoGrab ChristoGrab marked this pull request as ready for review July 5, 2024 20:52
@ChristoGrab ChristoGrab requested a review from a team as a code owner July 5, 2024 20:52
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge given the whole migrate-to-poetry will go away soon ;)

@ChristoGrab ChristoGrab enabled auto-merge (squash) July 5, 2024 21:04
@ChristoGrab ChristoGrab merged commit d0c56fd into master Jul 5, 2024
29 checks passed
@ChristoGrab ChristoGrab deleted the christo/airbyte-ci/migrate-to-poetry branch July 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants