Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination S3: check to verify prefix access instead of full-bucket access #4130

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

itaiad200
Copy link
Contributor

@itaiad200 itaiad200 commented Jun 15, 2021

closes #3989

What

The S3Destination connector tries to write to the bucket root as part of the connector checks.
Users shouldn't be forced to give the connector full access to the bucket, if they configured a prefix within the bucket.

How

Perform the check on an object under the prefix in the bucket.

Recommended reading order

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jun 15, 2021
@itaiad200 itaiad200 changed the title S3 destination check to verify prefix access instead of full-bucket access S3Destination check to verify prefix access instead of full-bucket access Jun 15, 2021
@marcosmarxm marcosmarxm changed the title S3Destination check to verify prefix access instead of full-bucket access Destination S3: check to verify prefix access instead of full-bucket access Jun 16, 2021
@tuliren tuliren merged commit a817d9c into airbytehq:master Jun 16, 2021
@tuliren tuliren mentioned this pull request Jun 16, 2021
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 destination should not require full bucket access
2 participants