airbyte-ci: trigger test on doc change #42046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
the
area/documentation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/07-17-airbyte-ci_trigger_test_on_doc_change
branch
from
1977836
to
8b2e3cb
Compare
octavia-squidington-iii
removed
the
area/documentation
alafanechere
force-pushed
the
augustin/07-17-airbyte-ci_trigger_test_on_doc_change
branch
from
8b2e3cb
to
7595168
Compare
alafanechere
force-pushed
the
augustin/07-17-airbyte-ci_trigger_test_on_doc_change
branch
2 times, most recently
from
54cbfc3
to
c694798
Compare
clnoll
approved these changes
Jul 17, 2024
| @@ -38,7 +38,7 @@ jobs: | |||
| # Note: expressions within a filter are OR'ed | |||
| filters: | | |||
| connectors: | |||
| - '*' | |||
There was a problem hiding this comment.
Looks like this was causing tests to run for all changes?
| @@ -32,7 +32,7 @@ | |||
| MANIFEST_FILE_NAME = "manifest.yaml" | |||
| METADATA_ICON_FILE_NAME = "icon.svg" | |||
| DIFF_FILTER = "MADRT" # Modified, Added, Deleted, Renamed, Type changed | |||
| IGNORED_FILE_EXTENSIONS = [".md"] | |||
| IGNORED_FILE_EXTENSIONS = [] | |||
There was a problem hiding this comment.
Is there any reason to keep this now that it's empty?
alafanechere
force-pushed
the
augustin/07-17-airbyte-ci_trigger_test_on_doc_change
branch
from
c694798
to
9ef886f
Compare
alafanechere
force-pushed
the
augustin/07-17-airbyte-ci_trigger_test_on_doc_change
branch
from
9ef886f
to
8c0f7d4
Compare
alafanechere
deleted the
augustin/07-17-airbyte-ci_trigger_test_on_doc_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/8960
A connector doc modification did not trigger connector tests.
This has to change now that we have tests on docs (in QA checks).
All connector tests will be triggered on doc change. If this turns out to be annoying we can change the control flow to skip code tests if only docs were modified.
@clnoll this implementation is slighlty different from what we groomed together. Please check out this comment for details.