Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 S3 destination: Avro & Jsonl output #4227

Merged
merged 18 commits into from
Jun 23, 2021
Merged

🎉 S3 destination: Avro & Jsonl output #4227

merged 18 commits into from
Jun 23, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jun 19, 2021 •
edited
Loading

What

Recommended reading order

  • s3.md
  • S3AvroWriter.java
  • S3JsonlWriter.java
  • spec.json

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 19, 2021
@tuliren tuliren marked this pull request as draft June 19, 2021 22:11
@tuliren tuliren changed the title 🎉 S3 destination: JSONL output 🎉 S3 destination: Avro & Jsonl output Jun 20, 2021
@tuliren
Copy link
Contributor Author

tuliren commented Jun 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/954291483
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/954291483

@tuliren tuliren marked this pull request as ready for review June 20, 2021 11:03
@tuliren tuliren requested review from davinchia and subodh1810 June 20, 2021 11:04
@tuliren tuliren requested review from ChristopheDuong and sherifnada and removed request for ChristopheDuong and davinchia June 21, 2021 01:41
ChristopheDuong
ChristopheDuong approved these changes Jun 22, 2021
View reviewed changes
docs/integrations/destinations/s3.md Outdated Show resolved Hide resolved
@tuliren
Copy link
Contributor Author

tuliren commented Jun 23, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/965864375
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/965864375

@tuliren tuliren merged commit e2c5b1d into master Jun 23, 2021
@tuliren tuliren deleted the liren/s3-jsonl branch June 23, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheDuong ChristopheDuong ChristopheDuong approved these changes

@subodh1810 subodh1810 Awaiting requested review from subodh1810

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @ChristopheDuong