airbyte-ci: run live tests against connection listed in metadata #42574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
3 times, most recently
from
7376bc3
to
74c3b4e
Compare
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
from
74c3b4e
to
d0fa5f2
Compare
clnoll
changed the title
clnoll
commented
Jul 26, 2024
| sentry_dsn: ${{ secrets.SENTRY_AIRBYTE_CI_DSN }} | ||
| git_branch: ${{ github.head_ref }} | ||
| git_revision: ${{ steps.fetch_last_commit_id_pr.outputs.commit_id }} | ||
| github_token: ${{ env.PAT }} | ||
| github_maintenance_token: ${{ secrets.GH_PAT_MAINTENANCE_OSS }} |
There was a problem hiding this comment.
I would prefer not to have to use this in addition to env.PAT, but env.PAT isn't scoped properly to run the live tests, and secrets. GH_PAT_MAINTENANCE_OSS isn't scoped properly for the rest of the tests.
alafanechere
requested changes
Jul 29, 2024
| @@ -50,6 +50,7 @@ def __init__( | |||
| ci_gcp_credentials: Optional[Secret] = None, | |||
| ci_git_user: Optional[str] = None, | |||
| ci_github_access_token: Optional[Secret] = None, | |||
| ci_github_maintenance_token: Optional[Secret] = None, | |||
There was a problem hiding this comment.
I'd really love to use ci_github_access_token here, and make the extra effort of generating a token / PAT with the right level of permissions. I don't think there's a strong reason to differentiate both token logically in code.
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/common.py
Show resolved
Hide resolved
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
from
d0fa5f2
to
dd250a4
Compare
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
from
885afa9
to
2256e56
Compare
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
from
ce1a216
to
0015590
Compare
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
from
16f815a
to
c5ec8d7
Compare
octavia-squidington-iii
removed
the
area/documentation
octavia-squidington-iii
added
area/documentation
clnoll
force-pushed
the
catherine/run-live-tests-against-metadata-connection
branch
from
de12765
to
54928cf
Compare
This reverts commit 54928cf.
octavia-squidington-iii
removed
the
area/documentation
|
❤️
|
BenGalewsky
pushed a commit
to BenGalewsky/airbyte
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the connectors test pipeline to run live tests if there's a sandbox account.
Depends on #42860 and #42577, which adds the live tests configuration info to the metadata.yaml for each connector that has a sandbox account in integration-test-sandboxes workspace.
Closes #42465.