Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: send publish failures to a dedicated slack channel #42849

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jul 29, 2024

What

Closes #42522
Closes #42521

  • Send connector specific publish failure messages from airbyte-ci to #connector-publish-failures
  • Send workflow failures to #connector-publish-failures (this will catch transient workflow failures when airbyte-ci can't start)
  • Continue sending all messages to #connector-publish-updates

How

  • Do not expose a custom option to define which slack channel to send messages to
  • Hardcode the list of targeted slack channels
  • Declare a PipelineContext.get_slack_channels method to return the list of channels to send a message to.
  • Implement a PublishContext.get_slack_channels method which returns targeted channels according to pipeline state
  • Make send_slack_webhook accept a list of channels to send a message to

Example

Screenshot 2024-07-29 at 16 06 29

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 8:07am

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

Copy link

sentry-io bot commented Jul 29, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/context.py

Function Unhandled Issue
__init__ ValueError: too many values to unpack (expected 2) pipelines.models.contexts.pipeline_context in <listcom...
Event Count: 3
📄 File: airbyte-ci/connectors/pipelines/pipelines/models/contexts/pipeline_context.py (Click to Expand)
Function Unhandled Issue
__init__ ValueError: too many values to unpack (expected 2) pipelines.models.contexts.pipeline_context in <listcom...
Event Count: 3
---

Did you find this useful? React with a 👍 or 👎

@alafanechere alafanechere force-pushed the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch from 3b4297a to ab2ef72 Compare July 29, 2024 12:07
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues connectors/source/faker and removed area/connectors Connector related issues labels Jul 29, 2024
@alafanechere alafanechere marked this pull request as ready for review July 29, 2024 12:27
@alafanechere alafanechere requested a review from a team as a code owner July 29, 2024 12:27
@alafanechere alafanechere force-pushed the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch 2 times, most recently from 30dd0f7 to 9d54545 Compare July 29, 2024 12:38
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jul 29, 2024
@alafanechere alafanechere changed the title airbyte-ci: send publish failures to a dedicated slack channels airbyte-ci: send publish failures to a dedicated slack channel Jul 29, 2024
@alafanechere alafanechere force-pushed the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch 5 times, most recently from addbcec to 3cc9efa Compare July 29, 2024 13:56
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jul 29, 2024
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @alafanechere!

@alafanechere alafanechere force-pushed the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch from 22e8bd9 to b5a53f8 Compare July 30, 2024 06:56
@alafanechere alafanechere enabled auto-merge (squash) July 30, 2024 07:02
@alafanechere alafanechere force-pushed the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch from b5a53f8 to 90b1323 Compare July 30, 2024 07:33
@alafanechere alafanechere force-pushed the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch from 90b1323 to 675b165 Compare July 30, 2024 08:07
@alafanechere alafanechere merged commit e4833f6 into master Jul 30, 2024
33 checks passed
@alafanechere alafanechere deleted the augustin/07-29-airbyte-ci_send_publish_failures_to_a_dedicated_slack_channels branch July 30, 2024 08:25
BenGalewsky pushed a commit to BenGalewsky/airbyte that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants