feat(bump-version): bump-version support for explicit version #42970
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bnchrch
force-pushed
the
08-02-feat_bump-version_bump-version_support_for_explicit_version
branch
from
b06b405
to
2618320
Compare
| version_str = value.split("version:", 1)[1] | ||
| if semver.VersionInfo.is_valid(version_str): | ||
| return value | ||
| self.fail(f"{value} is not a valid bump type. Valid choices are {self.choices} or 'version:<semver>'.", param, ctx) |
There was a problem hiding this comment.
| self.fail(f"{value} is not a valid bump type. Valid choices are {self.choices} or 'version:<semver>'.", param, ctx) | |
| self.fail(f"{value} is not a valid bump type. Valid choices are {self.choices} or 'version:<semver-version>'.", param, ctx) |
| return value | ||
| if value.startswith("version:"): | ||
| version_str = value.split("version:", 1)[1] | ||
| if semver.VersionInfo.is_valid(version_str): |
There was a problem hiding this comment.
Do we care that this allows for e.g. dev versions, alpha versions etc.? My guess is probably not, since we don't intend it to be used much.
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/steps/bump_version.py
Show resolved
Hide resolved
|
Thanks @erohmensing Since we dont need this ASAP. Im going to wait to see if @alafanechere has some comments. |
|
@bnchrch that's fine, we should just keep a sharp eye out for errors in that publish channel until this is merged :) |
There was a problem hiding this comment.
Haven't tested manually, but the code looks like it'd work.
Appease mypy gods:
pipelines/airbyte_ci/connectors/bump_version/commands.py:16: error: Function is missing a return type annotation [no-untyped-def]
pipelines/airbyte_ci/connectors/bump_version/commands.py:16: note: Use "-> None" if function does not return a value
pipelines/airbyte_ci/connectors/bump_version/commands.py:19: error: Function is missing a type annotation [no-untyped-def]
pipelines/airbyte_ci/connectors/bump_version/commands.py:28: error: Function is missing a type annotation [no-untyped-def]
Found 3 errors in 1 file (checked 156 source files)
| name = "bump-type" | ||
|
|
||
| def __init__(self): | ||
| self.choices = ["patch", "minor", "major"] |
There was a problem hiding this comment.
nit: wondering if there could be an enum with these values we could pulled from the semver lib
There was a problem hiding this comment.
Can you please update the bump-version doc?
bnchrch
force-pushed
the
08-02-feat_bump-version_bump-version_support_for_explicit_version
branch
2 times, most recently
from
efccd5f
to
f2db0de
Compare
bnchrch
force-pushed
the
08-02-feat_bump-version_bump-version_support_for_explicit_version
branch
from
f2db0de
to
03df7ac
Compare
bnchrch
deleted the
08-02-feat_bump-version_bump-version_support_for_explicit_version
branch
What
Updates
bump_versionto allow for explicit setting of a versionWhy
This is to support the temporary decision to keep source-declarative-manifest and the cdk with the same version
In the long term we plan to add a better way to resolve CDK to SDM versions on the platform