airbyte-ci: format should ignore airbyte-enterprise submodule #42972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
postamar
force-pushed
the
postamar/airbyte-ci-format-to-ignore-airbyte-submodule
branch
from
cbaa04e
to
0b176df
Compare
postamar
force-pushed
the
postamar/airbyte-ci-format-to-ignore-airbyte-submodule
branch
from
0b176df
to
7922c25
Compare
bnchrch
approved these changes
Aug 2, 2024
postamar
deleted the
postamar/airbyte-ci-format-to-ignore-airbyte-submodule
branch
BenGalewsky
pushed a commit
to BenGalewsky/airbyte
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
airbyte-ci formatdoesn't work in the airbyte-enterprise repo because (among other things) it applies itself to theairbyte-submodulegit submodule and the exclusion rules don't quite work. It should just ignore the whole submodule entirely.How
Adds the submodule to the exclusion list.
Review guide
n/a
User Impact
None
Can this PR be safely reverted and rolled back?