Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airbyte-ci): cleanup unused / empty schema directories after inlining schemas to manifests #43297

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

natikgadzhi
Copy link
Contributor

What

This pull request does two things:

  1. connectors migrate-to-inline_schemas will remove unused remaining json schemas and schemas directory.
  2. formatting helper uses logger for output so running this in CLI looks clean and nice.

@natikgadzhi natikgadzhi requested a review from a team as a code owner August 3, 2024 19:28
Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 6:05am

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented Aug 3, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (405b3e7)

@natikgadzhi natikgadzhi changed the title fix(airbyte-ci): use logger for formatting helper fix(airbyte-ci): cleanup unused / empty schema directories after inlining schemas to manifests Aug 3, 2024
@natikgadzhi
Copy link
Contributor Author

Hmm, that's weird.

@alafanechere could it somehow be connected to your work on always coupling streict-encrypt connectors?

___________ test_get_selected_connectors_with_modified_and_language ____________

    def test_get_selected_connectors_with_modified_and_language():
        first_modified_connector = pick_a_random_connector(language=ConnectorLanguage.PYTHON)
        second_modified_connector = pick_a_random_connector(language=ConnectorLanguage.JAVA, other_picked_connectors=[first_modified_connector])
        modified_files = ***first_modified_connector.code_directory / "setup.py", second_modified_connector.code_directory / "setup.py"***
        selected_connectors = connectors_commands.get_selected_connectors_with_modified_files(
            selected_names=(),
            selected_support_levels=(),
            selected_languages=(ConnectorLanguage.JAVA,),
            modified=True,
            metadata_changes_only=False,
            metadata_query=None,
            modified_files=modified_files,
        )
    
>       assert len(selected_connectors) == 1
E       AssertionError: assert 2 == 1
E        +  where 2 = len([ConnectorWithModifiedFiles(relative_connector_path='source-clickhouse', modified_files=frozenset(***PosixPath('airbyte-...)), ConnectorWithModifiedFiles(relative_connector_path='source-clickhouse-strict-encrypt', modified_files=frozenset())])

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@natikgadzhi natikgadzhi merged commit 7b65691 into master Aug 5, 2024
31 checks passed
@natikgadzhi natikgadzhi deleted the ng/airbyte-ci/inline-schemas-cleanup branch August 5, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants