fix changed_file indentation in airbyte-ci pull-request #43433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
bnchrch
approved these changes
Aug 9, 2024
natikgadzhi
approved these changes
Aug 9, 2024
| @@ -152,7 +152,7 @@ def create_or_update_github_pull_request( | |||
| content = base64.b64encode(file.read()).decode("utf-8") # Encode file content to base64 | |||
| blob = repo.create_git_blob(content, "base64") | |||
| changed_file = ChangedFile(path=str(modified_file), sha=blob.sha) | |||
| changed_files.append(changed_file) | |||
| changed_files.append(changed_file) | |||
There was a problem hiding this comment.
Given where it's assigned, you might have to indent it more, so it's all the way within the with block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When running the
pull-requestcommand, it intermittently fails with the error 'changed_file referenced before assignment'. The issue seems to be a minor indentation bug.User Impact
None, internal tool
Can this PR be safely reverted and rolled back?