-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix changed_file indentation in airbyte-ci pull-request #43433
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock. I think this works, and with
doesn't make a scope boundary and just makes sure the file is closed. Shipit!
@@ -152,7 +152,7 @@ def create_or_update_github_pull_request( | |||
content = base64.b64encode(file.read()).decode("utf-8") # Encode file content to base64 | |||
blob = repo.create_git_blob(content, "base64") | |||
changed_file = ChangedFile(path=str(modified_file), sha=blob.sha) | |||
changed_files.append(changed_file) | |||
changed_files.append(changed_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given where it's assigned, you might have to indent it more, so it's all the way within the with
block?
What
When running the
pull-request
command, it intermittently fails with the error 'changed_file referenced before assignment'. The issue seems to be a minor indentation bug.User Impact
None, internal tool
Can this PR be safely reverted and rolled back?