Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 9173] Ignore version check if only erd folder is changed #44465

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Aug 20, 2024

What

Following this PR, we see there are CI checks which are not needed when we change the ERD files.

How

Ignore these in VersionIncrementCheck

User Impact

A contributor updating the ERD file will not have to bump the version of the connector

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@maxi297 maxi297 requested a review from a team as a code owner August 20, 2024 19:20
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 0:36am

Co-authored-by: Augustin <augustin@airbyte.io>
@maxi297 maxi297 merged commit 5c47968 into master Aug 21, 2024
33 checks passed
@maxi297 maxi297 deleted the issue-9173/avoid-increment-check-on-erd-change branch August 21, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants