-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: promote and rollback publish pipeline for RC #44877
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
806550e
to
aab660b
Compare
2bbd5ef
to
ce20bb2
Compare
cf954e9
to
9cefd36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question for you!
) -> bool: | ||
|
||
if promote_release_candidate and rollback_release_candidate: | ||
raise click.UsageError("You can't promote and rollback a release candidate at the same time.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should all be mutually exclusive, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gaslighting the RC and saying that it definitely is going above and beyond, but no promotion this time. Classic.
aab660b
to
f54609d
Compare
9cefd36
to
5e7cd41
Compare
What
Relates to https://github.com/airbytehq/airbyte-internal-issues/issues/9254
In #44876 we introduce new metadata service command to promote and rollback a connector release candidate.
This PR orchestrate these commands in
airbyte-ci connectors publish
by declaring three rollout modes and related pipelines:RolloutMode.PUBLISH
: The original publish pipelineRolloutMode.ROLLBACK
: Calls the metadata servicerollback-release-candidate
commandRolloutMode.PROMOTE
: Calls the metadata servicepromote-release-candidate
command AND push thelatest
image tag to DockerHub.