airbyte-ci: promote and rollback publish pipeline for RC #44877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/08-28-airbyte-ci_publish_promote_and_rollback_release_candidates
branch
from
806550e
to
aab660b
Compare
alafanechere
force-pushed
the
augustin/08-28-airbyte-ci_promote_and_rollback_publish_pipeline_for_RC
branch
from
2bbd5ef
to
ce20bb2
Compare
alafanechere
force-pushed
the
augustin/08-28-airbyte-ci_promote_and_rollback_publish_pipeline_for_RC
branch
2 times, most recently
from
cf954e9
to
9cefd36
Compare
clnoll
approved these changes
Aug 29, 2024
| ) -> bool: | ||
|
|
||
| if promote_release_candidate and rollback_release_candidate: | ||
| raise click.UsageError("You can't promote and rollback a release candidate at the same time.") |
There was a problem hiding this comment.
These should all be mutually exclusive, right?
There was a problem hiding this comment.
Ah, gaslighting the RC and saying that it definitely is going above and beyond, but no promotion this time. Classic.
alafanechere
force-pushed
the
augustin/08-28-airbyte-ci_publish_promote_and_rollback_release_candidates
branch
from
aab660b
to
f54609d
Compare
alafanechere
force-pushed
the
augustin/08-28-airbyte-ci_promote_and_rollback_publish_pipeline_for_RC
branch
from
9cefd36
to
5e7cd41
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Relates to https://github.com/airbytehq/airbyte-internal-issues/issues/9254
In #44876 we introduce new metadata service command to promote and rollback a connector release candidate.
This PR orchestrate these commands in
airbyte-ci connectors publishby declaring three rollout modes and related pipelines:RolloutMode.PUBLISH: The original publish pipelineRolloutMode.ROLLBACK: Calls the metadata servicerollback-release-candidatecommandRolloutMode.PROMOTE: Calls the metadata servicepromote-release-candidatecommand AND push thelatestimage tag to DockerHub.