feat(CDK): enable shortened class_names in custom components #44881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
2 tasks
…/github.com/airbytehq/airbyte into christo/manifest-only-build-with-components
…ttps://github.com/airbytehq/airbyte into christo/low-code-cdk-update-components-module-path
2 tasks
ChristoGrab
changed the title
ChristoGrab
changed the base branch from
christo/manifest-only-build-with-components
to
master
ChristoGrab
deleted the
christo/low-code-cdk-update-components-module-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
What
Updates the resolving of fully_qualified_class_names in the manifest, allowing for simpler custom component class_names. Currently, a developer adding a custom component to the manifest must list its class_name as:
source_pokeapi.components.CustomPokeRetrieverWith this update, it can be simplified to
components.CustomPokeRetrieverResolves #9534
How
_get_connector_moduleto parse the name of the connector's module by scanning the directory of the main execution script for the relevant directory name.None).Review guide
Loom will be linked here shortly
User Impact
No impact on users. Developer-oriented update
Can this PR be safely reverted and rolled back?