🎉 New Source: Kustomer

[rparrapy]

What

Adds a Kustomer connector.

How

Wrapping the existing Singer tap.

Pre-merge Checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• Secrets are annotated with airbyte_secret in the connector's spec
• Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
• Unit & integration tests added as appropriate (and are passing)
  • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• /test connector=connectors/<name> command as documented here is passing.
  • Community members can skip this, Airbyters will run this for you.
• Code reviews completed
• Documentation updated
  • README.md
  • docs/SUMMARY.md if it's a new connector
  • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
  • Changelog in the appropriate page in docs/integrations/.... See changelog example
  • docs/integrations/README.md contains a reference to the new connector
  • Build status added to build page
• Build is successful
• Connector version bumped like described here
• New Connector version released on Dockerhub by running the /publish command described here
• No major blockers
• PR merged into master branch
• Follow up tickets have been created
• Associated tickets have been closed & stakeholders notified

This closes #4004

[rparrapy]

I cannot get the acceptance tests for incremental syncs in airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_incremental.py to pass, mainly because Singer's state does not conform with what those tests expect.

This is what the connector state looks like:

  {
    "bookmarks": {
      "conversations": "2019-12-26T18:35:41.583Z",
      "customers": "2019-12-26T18:39:38.186Z",
      "kobjects": "2019-12-26T18:24:18.283Z",
      "messages": "2019-12-26T18:39:45.018Z",
      "shortcuts": "2019-12-25T18:00:00Z",
      "tags": "2019-12-25T18:00:00Z",
      "users": "2019-12-25T18:00:00Z"
    },
    "currently_syncing": "teams"
  }

I noticed that the Github source that is referenced as an example for singer-based connectors does not run acceptance tests either. Is the acceptance test criteria relaxed for Singer-based connectors or else please let me know how to proceed to get this merged.

[sherifnada]

LGTM @rparrapy -- for incremental once https://github.com/airbytehq/airbyte/pull/4552/files is merged you should be able to move forward on this issue (you might need to docker pull the acceptance test image)

then can you post the output for the remaining tests?

[sherifnada]

Suggested change

	return AirbyteConnectionStatus(status=Status.FAILED, message=f"An exception occurred: {str(e)}")
	return AirbyteConnectionStatus(status=Status.FAILED, message=f"An exception occurred: {repr(e)}")

[rparrapy]

Finally got some time to wrap this up.

[rparrapy]

If we could get this merged this week based on the green integration tests that'd be great for my current project.

[sherifnada]

Apologies @rparrapy - have been slammed. Will do it tonight!

[sherifnada]

@rparrapy this has been published. Thank you for the contribution!! 🎉