Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source Apple Search Ads : Migrate to Manifest-only #46288

Merged
merged 5 commits into from
Oct 5, 2024
Merged

✨ Source Apple Search Ads : Migrate to Manifest-only #46288

merged 5 commits into from
Oct 5, 2024

Conversation

topefolorunso
Copy link
Collaborator

What

Migrate Source Apple Search Ads to Manifest-only

How

Review guide

  1. manifest.yaml

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 4:13pm

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Oct 1, 2024 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (c3c3777)

@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 1, 2024 15:55
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 1, 2024
@natikgadzhi
Copy link
Contributor

Regression tests refuse to run ;( they're not failing, they just didn't run. Same thing that is blocking @pabloescoder on a few PRs. I'll try to get to this this week.

natikgadzhi
natikgadzhi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, if the streams are tested, I would be down to merge this. Just confirming they are.

airbyte-integrations/connectors/source-apple-search-ads/manifest.yaml
- errorHandler
global:
- authenticator
testedStreams:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topefolorunso did you actually have test data to verify these? Not copy and pastedfrom another connector, right? ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not tested yet. Still waiting on @ChristoGrab for creds

Copy link
Contributor

@ChristoGrab ChristoGrab Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this now. We have an existing account in LastPass, but no Oauth creds. Working through the steps to generate them

@natikgadzhi natikgadzhi merged commit 46802b9 into master Oct 5, 2024
42 of 43 checks passed
@natikgadzhi natikgadzhi deleted the tope/apple-search-ads/migrate-manifest-only branch October 5, 2024 04:17
@natikgadzhi
Copy link
Contributor

Yolo, let's move forward. I'll revert if we see any problems with this, and ask @topefolorunso to fix them.

@topefolorunso topefolorunso mentioned this pull request Oct 5, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

@ChristoGrab ChristoGrab Awaiting requested review from ChristoGrab

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/apple-search-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topefolorunso @natikgadzhi @ChristoGrab @octavia-squidington-iii