-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ Source Apple Search Ads : Migrate to Manifest-only #46288
β¨ Source Apple Search Ads : Migrate to Manifest-only #46288
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
/format-fix
|
β¦/github.com/airbytehq/airbyte into tope/apple-search-ads/migrate-manifest-only
Regression tests refuse to run ;( they're not failing, they just didn't run. Same thing that is blocking @pabloescoder on a few PRs. I'll try to get to this this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, if the streams are tested, I would be down to merge this. Just confirming they are.
- errorHandler | ||
global: | ||
- authenticator | ||
testedStreams: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@topefolorunso did you actually have test data to verify these? Not copy and pastedfrom another connector, right? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No not tested yet. Still waiting on @ChristoGrab for creds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this now. We have an existing account in LastPass, but no Oauth creds. Working through the steps to generate them
Yolo, let's move forward. I'll revert if we see any problems with this, and ask @topefolorunso to fix them. |
What
Migrate Source Apple Search Ads to Manifest-only
How
Review guide
manifest.yaml
User Impact
Can this PR be safely reverted and rolled back?