Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub out the GCP Env Var in Docker to prevent noisy and harmless errors. #4642

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Stub out the GCP Env Var in Docker to prevent noisy and harmless errors. #4642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be265b7
Add this to prevent noisy errors.
davinchia Jul 9, 2021
8fa132b
Propagate variables to docker file.
davinchia Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ AWS_SECRET_ACCESS_KEY=
S3_MINIO_ENDPOINT=
S3_PATH_STYLE_ACCESS=

GCP_STORAGE_BUCKET=

# Docker Resource Limits
RESOURCE_CPU_REQUEST=
RESOURCE_CPU_LIMIT=
Expand Down
2 changes: 2 additions & 0 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ services:
- S3_LOG_BUCKET_REGION=${S3_LOG_BUCKET_REGION}
- AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
- AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
- GCP_STORAGE_BUCKET=${GCP_STORAGE_BUCKET}
- LOG_LEVEL=${LOG_LEVEL}
- RESOURCE_CPU_REQUEST=${RESOURCE_CPU_REQUEST}
- RESOURCE_CPU_LIMIT=${RESOURCE_CPU_LIMIT}
Expand Down Expand Up @@ -88,6 +89,7 @@ services:
- S3_LOG_BUCKET_REGION=${S3_LOG_BUCKET_REGION}
- AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
- AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
- GCP_STORAGE_BUCKET=${GCP_STORAGE_BUCKET}
- LOG_LEVEL=${LOG_LEVEL}
- RESOURCE_CPU_REQUEST=${RESOURCE_CPU_REQUEST}
- RESOURCE_CPU_LIMIT=${RESOURCE_CPU_LIMIT}
Expand Down