Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on MYSQL normalization flag. #4651

Merged
merged 11 commits into from
Jul 9, 2021
Merged

Turn on MYSQL normalization flag. #4651

merged 11 commits into from
Jul 9, 2021

Commits on Jul 9, 2021

  1. Turn on normalization flag. Bump version.

    @davinchia
    davinchia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    863a311 View commit details
    Browse the repository at this point in the history

  2. Update PR build.

    @davinchia
    davinchia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    2c33294 View commit details
    Browse the repository at this point in the history

  3. Supports normalisation is true.

    @davinchia
    davinchia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    f176b6b View commit details
    Browse the repository at this point in the history

  4. Use normalisation image to make sure the right binaries are present.

    @davinchia
    davinchia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    485b919 View commit details
    Browse the repository at this point in the history

  5. Checkpoint: Get this to a working state.

    @davinchia
    davinchia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    ae607d7 View commit details
    Browse the repository at this point in the history

  6. Fix tests and bump images

    @ChristopheDuong
    ChristopheDuong committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    c5ed287 View commit details
    Browse the repository at this point in the history

  7. Update comments

    @ChristopheDuong
    ChristopheDuong committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    debcea2 View commit details
    Browse the repository at this point in the history

  8. Update type_conversions.sql 

    fix typo in comment
    @ChristopheDuong
    ChristopheDuong authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b117b85 View commit details
    Browse the repository at this point in the history

  9. format code

    @ChristopheDuong
    ChristopheDuong committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    a9e207c View commit details
    Browse the repository at this point in the history

  10. Add test to remind turning normalization boolean on in spec

    @ChristopheDuong
    ChristopheDuong committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    672b1b2 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
    @ChristopheDuong @sherifnada
    ChristopheDuong and sherifnada authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    c055075 View commit details
    Browse the repository at this point in the history