Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format zendesk sunshine connector #4658

Merged
merged 1 commit into from
Jul 9, 2021
Merged

format zendesk sunshine connector #4658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions ...integrations/connectors/source-zendesk-sunshine/integration_tests/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@
}
}
},
"supported_sync_modes": [
"full_refresh",
"incremental"
],
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": []
},
Expand Down Expand Up @@ -71,10 +68,7 @@
}
}
},
"supported_sync_modes": [
"full_refresh",
"incremental"
],
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"]
},
Expand Down Expand Up @@ -105,10 +99,7 @@
}
}
},
"supported_sync_modes": [
"full_refresh",
"incremental"
],
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": []
},
Expand Down Expand Up @@ -139,10 +130,7 @@
}
}
},
"supported_sync_modes": [
"full_refresh",
"incremental"
],
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": []
},
Expand Down Expand Up @@ -217,10 +205,7 @@
}
}
},
"supported_sync_modes": [
"full_refresh",
"incremental"
],
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": []
},
Expand All @@ -245,10 +230,7 @@
}
}
},
"supported_sync_modes": [
"full_refresh",
"incremental"
],
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": []
},
Expand Down
9 changes: 1 addition & 8 deletions airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,7 @@
from airbyte_cdk.sources.streams import Stream
from airbyte_cdk.sources.streams.http.auth import TokenAuthenticator

from .streams import (
Limits,
ObjectRecords,
ObjectTypePolicies,
ObjectTypes,
RelationshipRecords,
RelationshipTypes,
)
from .streams import Limits, ObjectRecords, ObjectTypePolicies, ObjectTypes, RelationshipRecords, RelationshipTypes


class Base64HttpAuthenticator(TokenAuthenticator):
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"title": "Zendesk Sunshine Spec",
"type": "object",
"required": ["api_token", "email", "start_date" ,"subdomain"],
"required": ["api_token", "email", "start_date", "subdomain"],
"additionalProperties": false,
"properties": {
"api_token": {
Expand Down
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class ObjectRecords(IncrementalSunshineStream):
To support Incremental for this stream I had to use `query` endpoint instead of `objects/records` -
this allows me to use date filters. This is the only way to have incremental support.
"""

http_method = "POST"

def request_body_json(
Expand Down Expand Up @@ -213,6 +214,7 @@ class Jobs(SunshineStream):
This stream is dynamic. The data can exist today, but may be absent tomorrow.
Since we need to have some data in the stream this stream is disabled.
"""

def path(self, **kwargs) -> str:
return "jobs"

Expand Down