Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Stripe Source: Fix subscriptions stream to return all kinds of subscriptions (including expired and canceled) #4669

Merged
merged 28 commits into from
Jul 16, 2021
Merged

🎉 Stripe Source: Fix subscriptions stream to return all kinds of subscriptions (including expired and canceled) #4669

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4add496
added status param to Subscriptions Stream
annalvova05 Jul 9, 2021
85a42e6
updated version
annalvova05 Jul 9, 2021
b3f5f6c
removed params['created[gte]'] from Subscriptions stream
bazarnov Jul 13, 2021
93ac56b
removed Changedlog.md, edited docs/integrations/stripe changelog for …
bazarnov Jul 13, 2021
d34fd79
added expected_records_example for subscriptions status
bazarnov Jul 13, 2021
d310f84
changed docs/integrations/sources/stripe changelog
bazarnov Jul 13, 2021
49e0ce0
added source-acceptance-test capability + test for subscriptions
bazarnov Jul 14, 2021
47677eb
changed setup.py, remove source-acceptance-test dependency
bazarnov Jul 14, 2021
131a5ee
added all_statuses_subscription_catalog.json, changed docs
bazarnov Jul 14, 2021
1f32efa
changed docs
bazarnov Jul 14, 2021
a0fe6c2
changed docs
bazarnov Jul 14, 2021
0da30a4
added configured_catalog.json for acceptance-tests
bazarnov Jul 14, 2021
8fe591f
Merge remote-tracking branch 'origin/master' into alvova/4374-stripe-…
bazarnov Jul 14, 2021
1aea3cd
small changes to acceptance-test
bazarnov Jul 14, 2021
9faf8db
changed ci_credentials.sh, removed source-stripe connected_account_co…
bazarnov Jul 14, 2021
110e0df
changed ci_credentials.sh to use connected_account_config.json
bazarnov Jul 14, 2021
4a21423
changed ci_credentials.sh back to use config.json
bazarnov Jul 14, 2021
458b6da
changed ci_credentials.sh to accept the new secret
bazarnov Jul 14, 2021
1664662
changes ci_creds
bazarnov Jul 14, 2021
9f49521
changed the secret inside test, publish command
bazarnov Jul 14, 2021
44971cc
...
bazarnov Jul 14, 2021
f149fc6
...
bazarnov Jul 14, 2021
0b3bc01
Merge remote-tracking branch 'origin/master' into alvova/4374-stripe-…
bazarnov Jul 15, 2021
d578020
Merge remote-tracking branch 'origin/master' into alvova/4374-stripe-…
bazarnov Jul 15, 2021
834d345
changed schemas, changed acceptance-tests
bazarnov Jul 16, 2021
bf7152d
changed no_disputes_catalog.json
bazarnov Jul 16, 2021
c3d269b
changed formating
bazarnov Jul 16, 2021
78ae348
Merge remote-tracking branch 'origin/master' into alvova/4374-stripe-…
bazarnov Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/e094cb9a-26de-4645-8761-65c0c425d1de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "e094cb9a-26de-4645-8761-65c0c425d1de",
"name": "Stripe",
"dockerRepository": "airbyte/source-stripe",
"dockerImageTag": "0.1.13",
"dockerImageTag": "0.1.14",
"documentationUrl": "https://hub.docker.com/r/airbyte/source-stripe",
"icon": "stripe.svg"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
- sourceDefinitionId: e094cb9a-26de-4645-8761-65c0c425d1de
name: Stripe
dockerRepository: airbyte/source-stripe
dockerImageTag: 0.1.13
dockerImageTag: 0.1.14
documentationUrl: https://hub.docker.com/r/airbyte/source-stripe
icon: stripe.svg
- sourceDefinitionId: b03a9f3e-22a5-11eb-adc1-0242ac120002
Expand Down
4 changes: 0 additions & 4 deletions airbyte-integrations/connectors/source-stripe/CHANGELOG.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-stripe/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.13
LABEL io.airbyte.version=0.1.14
LABEL io.airbyte.name=airbyte/source-stripe
19 changes: 19 additions & 0 deletions ...s/connectors/source-stripe/integration_tests/expected_subscriptions_statuses_records.json
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions airbyte-integrations/connectors/source-stripe/source_stripe/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,17 @@ def path(self, **kwargs):

class Subscriptions(IncrementalStripeStream):
cursor_field = "created"
status = "all"

def path(self, **kwargs):
return "subscriptions"

def request_params(self, stream_state=None, **kwargs):
stream_state = stream_state or {}
params = super().request_params(stream_state=stream_state, **kwargs)
params["status"] = self.status
return params


class SubscriptionItems(StripeStream):
name = "subscription_items"
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/stripe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ If you would like to test Airbyte using test data on Stripe, `sk_test_` and `rk_

| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| 0.1.14 | 2021-07-09 | [4669](https://github.com/airbytehq/airbyte/pull/4669) | Subscriptions Stream now returns all kinds of subscriptions (including expired and canceled)|
| 0.1.13 | 2021-07-03 | [4528](https://github.com/airbytehq/airbyte/pull/4528) | Remove regex for acc validation |
| 0.1.12 | 2021-06-08 | [3973](https://github.com/airbytehq/airbyte/pull/3973) | Add `AIRBYTE_ENTRYPOINT` for Kubernetes support |
| 0.1.11 | 2021-05-30 | [3744](https://github.com/airbytehq/airbyte/pull/3744) | Fix types in schema |
Expand Down