Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Destination Snowflake: tag snowflake traffic with airbyte ID to enable optimizations from Snowflake #4713

Merged
merged 5 commits into from
Jul 13, 2021
Merged

🎉 Destination Snowflake: tag snowflake traffic with airbyte ID to enable optimizations from Snowflake #4713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06f12f2
tag snowflake trafic with airbyte ID
sherifnada Jul 12, 2021
5287319
save
sherifnada Jul 12, 2021
6a683fa
fix tests
sherifnada Jul 13, 2021
5e78d3f
format
sherifnada Jul 13, 2021
0fa2238
fix
sherifnada Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...esources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"destinationDefinitionId": "424892c4-daac-4491-b35d-c6688ba547ba",
"name": "Snowflake",
"dockerRepository": "airbyte/destination-snowflake",
"dockerImageTag": "0.3.9",
"dockerImageTag": "0.3.10",
"documentationUrl": "https://docs.airbyte.io/integrations/destinations/snowflake"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
- destinationDefinitionId: 424892c4-daac-4491-b35d-c6688ba547ba
name: Snowflake
dockerRepository: airbyte/destination-snowflake
dockerImageTag: 0.3.9
dockerImageTag: 0.3.10
documentationUrl: https://docs.airbyte.io/integrations/destinations/snowflake
- destinationDefinitionId: 4816b78f-1489-44c1-9060-4b19d5fa9362
name: S3
Expand Down
18 changes: 12 additions & 6 deletions ...main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,10 @@ public void testSecondSync() throws Exception {
.put("id", 1)
.put("currency", "USD")
.put("date", "2020-03-31T00:00:00Z")
.put("HKD", 10.0)
.put("NZD", 700.0)
// TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which
// fails destination tests
.put("HKD", 10.1)
.put("NZD", 700.1)
.build()))),
new AirbyteMessage()
.withType(Type.STATE)
Expand Down Expand Up @@ -405,8 +407,10 @@ public void testLineBreakCharacters() throws Exception {
.put("id", 1)
.put("currency", "USD\u2028")
.put("date", "2020-03-\n31T00:00:00Z\r")
.put("HKD", 10.0)
.put("NZD", 700.0)
// TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which
// fails destination tests
.put("HKD", 10.1)
.put("NZD", 700.1)
.build()))),
new AirbyteMessage()
.withType(Type.STATE)
Expand Down Expand Up @@ -470,8 +474,10 @@ public void testIncrementalSync() throws Exception {
.put("id", 1)
.put("currency", "USD")
.put("date", "2020-03-31T00:00:00Z")
.put("HKD", 10.0)
.put("NZD", 700.0)
// TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which
// fails destination tests
.put("HKD", 10.1)
.put("NZD", 700.1)
.build()))),
new AirbyteMessage()
.withType(Type.STATE)
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-snowflake/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar

RUN tar xf ${APPLICATION}.tar --strip-components=1

LABEL io.airbyte.version=0.3.9
LABEL io.airbyte.version=0.3.10
LABEL io.airbyte.name=airbyte/destination-snowflake
4 changes: 4 additions & 0 deletions ...wflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ public static Connection getConnection(JsonNode config) throws SQLException {
// allows queries to contain any number of statements.
properties.put("MULTI_STATEMENT_COUNT", 0);

// https://docs.snowflake.com/en/user-guide/jdbc-parameters.html#application
// identify airbyte traffic to snowflake to enable partnership & optimization opportunities
properties.put("application", "airbyte");

return DriverManager.getConnection(connectUrl, properties);
}

Expand Down
5 changes: 5 additions & 0 deletions docs/integrations/destinations/snowflake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,8 @@ The final query should show a `STORAGE_GCP_SERVICE_ACCOUNT` property with an ema

Finally, you need to add read/write permissions to your bucket with that email.


| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| 0.3.10 | July 12, 2021| [4713](https://github.com/airbytehq/airbyte/pull/4713)| Tag traffic with `airbyte` label to enable optimization opportunities from Snowflake |

2 changes: 1 addition & 1 deletion docs/integrations/sources/stripe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ If you would like to test Airbyte using test data on Stripe, `sk_test_` and `rk_
| 0.1.11 | 2021-05-30 | [3744](https://github.com/airbytehq/airbyte/pull/3744) | Fix types in schema |
| 0.1.10 | 2021-05-28 | [3728](https://github.com/airbytehq/airbyte/pull/3728) | Update data types to be number instead of int |
| 0.1.9 | 2021-05-13 | [3367](https://github.com/airbytehq/airbyte/pull/3367) | Add acceptance tests for connected accounts |
| 0.1.8 | 2021-05-11 | [3566](https://github.com/airbytehq/airbyte/pull/3368) | Bump CDK connectors |
| 0.1.8 | 2021-05-11 | [3566](https://github.com/airbytehq/airbyte/pull/3368) | Bump CDK connectors |