airbyte-ci: fix add changelog entry in up-to-date #47189
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/10-21-airbyte-ci_fix_add_changelog_entry_in_up-to-date
branch
from
c4c2e4f
to
fd87f67
Compare
alafanechere
force-pushed
the
augustin/10-21-airbyte-ci_fix_add_changelog_entry_in_up-to-date
branch
from
fd87f67
to
dcebd41
Compare
natikgadzhi
approved these changes
Oct 21, 2024
| @@ -164,7 +164,9 @@ async def run_connector_up_to_date_pipeline( | |||
| step_results.append(add_changelog_entry_result) | |||
| if add_changelog_entry_result.success: | |||
| # File path modified by the changelog entry step are relative to the repo root | |||
| exported_modified_files = await add_changelog_entry.export_modified_files(Path(".")) | |||
| exported_modified_files = await add_changelog_entry.export_modified_files( | |||
| context.connector.local_connector_documentation_directory | |||
alafanechere
deleted the
augustin/10-21-airbyte-ci_fix_add_changelog_entry_in_up-to-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
up-do-dateexports docs update back to a wrong path following a refacto I made.Fixing it.