Amazon Ads: add new stream SponsoredDisplayV3ReportStream
#47366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
octavia-squidington-iii
added
the
area/documentation
bazarnov
approved these changes
Oct 25, 2024
| group_by = ["campaign"] | ||
| filters = [] | ||
|
|
||
| if record_type == "adGroups": |
There was a problem hiding this comment.
Can we have a mapping of values {reportType: (reportTypeId, groupBy, filters)} instead of if...else, and parse it accordingly using get_body() method or similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/10360
First step in amazon ads enhancement, see full tasklist in https://github.com/airbytehq/airbyte-internal-issues/issues/10429
I decided to leave the old one as is and introduce new one to avoid breaking changes (top-level schema remains the same, but metrics have been changed).
We could remove old stream after bumping the CDK to gracefully wrap non-existing-stream error.
How
add new stream:
SponsoredDisplayV3ReportStreamReview guide
airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/display_report.pyUser Impact
Can this PR be safely reverted and rolled back?