Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder #4816

Merged
merged 1 commit into from
Jul 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added airbyte-webapp/public/empty-connections.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added airbyte-webapp/public/empty-destinations.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added airbyte-webapp/public/empty-sources.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
27 changes: 27 additions & 0 deletions airbyte-webapp/src/components/Placeholder/Placeholder.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import React from "react";
import styled from "styled-components";
import { ResourceTypes } from "./types";

type PlaceholderProps = {
resource: ResourceTypes;
};

const Img = styled.img<PlaceholderProps>`
max-height: ${({ resource }) =>
resource === ResourceTypes.Connections
? "465"
: resource === ResourceTypes.Destinations
? "409"
: "534"}px;
max-width: 100%;
margin: 100px auto 0;
display: block;
`;

const Placeholder: React.FC<PlaceholderProps> = ({ resource }) => {
return (
<Img src={`/empty-${resource}.png`} alt="placeholder" resource={resource} />
);
};

export default Placeholder;
5 changes: 5 additions & 0 deletions airbyte-webapp/src/components/Placeholder/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import Placeholder from "./Placeholder";
import { ResourceTypes } from "./types";

export default Placeholder;
export { Placeholder, ResourceTypes };
5 changes: 5 additions & 0 deletions airbyte-webapp/src/components/Placeholder/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export enum ResourceTypes {
Sources = "sources",
Connections = "connections",
Destinations = "destinations",
}
Original file line number Diff line number Diff line change
@@ -1,26 +1,15 @@
import React, { Suspense } from "react";
import { FormattedMessage } from "react-intl";
import { useResource } from "rest-hooks";
import styled from "styled-components";

import {
Button,
MainPageWithScroll,
PageTitle,
LoadingPage,
ContentCard,
} from "components";
import { Button, MainPageWithScroll, PageTitle, LoadingPage } from "components";
import ConnectionResource from "core/resources/Connection";
import config from "config";
import ConnectionsTable from "./components/ConnectionsTable";
import { Routes } from "pages/routes";
import useRouter from "components/hooks/useRouterHook";
import EmptyResource from "components/EmptyResourceBlock";
import HeadTitle from "components/HeadTitle";

const Content = styled(ContentCard)`
margin: 0 32px 0 27px;
`;
import Placeholder, { ResourceTypes } from "components/Placeholder";

const AllConnectionsPage: React.FC = () => {
const { push } = useRouter();
Expand Down Expand Up @@ -49,11 +38,7 @@ const AllConnectionsPage: React.FC = () => {
{connections.length ? (
<ConnectionsTable connections={connections} />
) : (
<Content>
<EmptyResource
text={<FormattedMessage id="connection.noConnections" />}
/>
</Content>
<Placeholder resource={ResourceTypes.Connections} />
)}
</Suspense>
</MainPageWithScroll>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,16 @@
import React from "react";
import { FormattedMessage } from "react-intl";
import styled from "styled-components";
import { useResource } from "rest-hooks";

import { Button } from "components";
import { Button, MainPageWithScroll } from "components";
import { Routes } from "../../../routes";
import PageTitle from "components/PageTitle";
import useRouter from "components/hooks/useRouterHook";
import DestinationsTable from "./components/DestinationsTable";
import config from "config";
import ContentCard from "components/ContentCard";
import EmptyResource from "components/EmptyResourceBlock";
import DestinationResource from "core/resources/Destination";
import HeadTitle from "components/HeadTitle";

const Content = styled(ContentCard)`
margin: 0 32px 0 27px;
`;
import Placeholder, { ResourceTypes } from "components/Placeholder";

const AllDestinationsPage: React.FC = () => {
const { push } = useRouter();
Expand All @@ -29,26 +23,25 @@ const AllDestinationsPage: React.FC = () => {
push(`${Routes.Destination}${Routes.DestinationNew}`);

return (
<>
<HeadTitle titles={[{ id: "admin.destinations" }]} />
<PageTitle
title={<FormattedMessage id="admin.destinations" />}
endComponent={
<Button onClick={onCreateDestination} data-id="new-destination">
<FormattedMessage id="destination.newDestination" />
</Button>
}
/>
<MainPageWithScroll
headTitle={<HeadTitle titles={[{ id: "admin.destinations" }]} />}
pageTitle={
<PageTitle
title={<FormattedMessage id="admin.destinations" />}
endComponent={
<Button onClick={onCreateDestination} data-id="new-destination">
<FormattedMessage id="destination.newDestination" />
</Button>
}
/>
}
>
{destinations.length ? (
<DestinationsTable destinations={destinations} />
) : (
<Content>
<EmptyResource
text={<FormattedMessage id="destinations.noDestinations" />}
/>
</Content>
<Placeholder resource={ResourceTypes.Destinations} />
)}
</>
</MainPageWithScroll>
);
};

Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import React, { Suspense, useMemo, useState } from "react";
import { FormattedMessage } from "react-intl";
import styled from "styled-components";
import { useResource } from "rest-hooks";

import PageTitle from "components/PageTitle";
import useRouter from "components/hooks/useRouterHook";
import config from "config";
import ContentCard from "components/ContentCard";
import EmptyResource from "components/EmptyResourceBlock";
import Placeholder, { ResourceTypes } from "components/Placeholder";
import ConnectionResource from "core/resources/Connection";
import { Routes } from "../../../routes";
import Breadcrumbs from "components/Breadcrumbs";
Expand All @@ -28,10 +26,6 @@ import ImageBlock from "components/ImageBlock";
import SourceDefinitionResource from "core/resources/SourceDefinition";
import HeadTitle from "components/HeadTitle";

const Content = styled(ContentCard)`
margin: 0 32px 0 27px;
`;

const DestinationItemPage: React.FC = () => {
const { query, push } = useRouter<{ id: string }>();

Expand Down Expand Up @@ -140,14 +134,7 @@ const DestinationItemPage: React.FC = () => {
connections={connectionsWithDestination}
/>
) : (
<Content>
<EmptyResource
text={<FormattedMessage id="destinations.noSources" />}
description={
<FormattedMessage id="destinations.addSourceReplicateData" />
}
/>
</Content>
<Placeholder resource={ResourceTypes.Sources} />
)}
</>
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,16 @@
import React from "react";
import { FormattedMessage } from "react-intl";
import styled from "styled-components";
import { useResource } from "rest-hooks";

import { Button } from "components";
import { Button, MainPageWithScroll } from "components";
import { Routes } from "../../../routes";
import PageTitle from "components/PageTitle";
import useRouter from "components/hooks/useRouterHook";
import SourcesTable from "./components/SourcesTable";
import config from "config";
import ContentCard from "components/ContentCard";
import EmptyResource from "components/EmptyResourceBlock";
import SourceResource from "core/resources/Source";
import HeadTitle from "components/HeadTitle";

const Content = styled(ContentCard)`
margin: 0 32px 0 27px;
`;
import Placeholder, { ResourceTypes } from "components/Placeholder";

const AllSourcesPage: React.FC = () => {
const { push } = useRouter();
Expand All @@ -27,24 +21,25 @@ const AllSourcesPage: React.FC = () => {

const onCreateSource = () => push(`${Routes.Source}${Routes.SourceNew}`);
return (
<>
<HeadTitle titles={[{ id: "admin.sources" }]} />
<PageTitle
title={<FormattedMessage id="sidebar.sources" />}
endComponent={
<Button onClick={onCreateSource} data-id="new-source">
<FormattedMessage id="sources.newSource" />
</Button>
}
/>
<MainPageWithScroll
headTitle={<HeadTitle titles={[{ id: "admin.sources" }]} />}
pageTitle={
<PageTitle
title={<FormattedMessage id="sidebar.sources" />}
endComponent={
<Button onClick={onCreateSource} data-id="new-source">
<FormattedMessage id="sources.newSource" />
</Button>
}
/>
}
>
{sources.length ? (
<SourcesTable sources={sources} />
) : (
<Content>
<EmptyResource text={<FormattedMessage id="sources.noSources" />} />
</Content>
<Placeholder resource={ResourceTypes.Sources} />
)}
</>
</MainPageWithScroll>
);
};

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { Suspense, useMemo, useState } from "react";
import { FormattedMessage } from "react-intl";
import styled from "styled-components";
import { useResource } from "rest-hooks";

import config from "config";
Expand All @@ -9,8 +8,6 @@ import { Routes } from "pages/routes";
import { ImageBlock } from "components";
import PageTitle from "components/PageTitle";
import useRouter from "components/hooks/useRouterHook";
import ContentCard from "components/ContentCard";
import EmptyResource from "components/EmptyResourceBlock";
import Breadcrumbs from "components/Breadcrumbs";
import {
ItemTabs,
Expand All @@ -31,10 +28,7 @@ import SourceDefinitionResource from "core/resources/SourceDefinition";
import DestinationsDefinitionResource from "core/resources/DestinationDefinition";
import { getIcon } from "utils/imageUtils";
import HeadTitle from "components/HeadTitle";

const Content = styled(ContentCard)`
margin: 0 32px 0 27px;
`;
import Placeholder, { ResourceTypes } from "components/Placeholder";

const SourceItemPage: React.FC = () => {
const { query, push } = useRouter<{ id: string }>();
Expand Down Expand Up @@ -131,14 +125,7 @@ const SourceItemPage: React.FC = () => {
{connectionsWithSource.length ? (
<SourceConnectionTable connections={connectionsWithSource} />
) : (
<Content>
<EmptyResource
text={<FormattedMessage id="sources.noDestinations" />}
description={
<FormattedMessage id="sources.addDestinationReplicateData" />
}
/>
</Content>
<Placeholder resource={ResourceTypes.Destinations} />
)}
</>
);
Expand Down