-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deployments to tracking model #4837
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
78 changes: 78 additions & 0 deletions
78
airbyte-analytics/src/main/java/io/airbyte/analytics/Deployment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/* | ||
* MIT License | ||
* | ||
* Copyright (c) 2020 Airbyte | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
package io.airbyte.analytics; | ||
|
||
import com.google.common.base.Preconditions; | ||
import io.airbyte.config.Configs; | ||
import io.airbyte.config.Configs.WorkerEnvironment; | ||
import java.util.UUID; | ||
|
||
public class Deployment { | ||
|
||
public enum DeploymentMode { | ||
OSS, | ||
CLOUD | ||
} | ||
|
||
/** | ||
* deployment - deployment tracking info. | ||
*/ | ||
private final DeploymentMode deploymentMode; | ||
/** | ||
* deploymentId - Identifier for the deployment. | ||
* | ||
* This identifier tracks an install of Airbyte. Any time Airbyte is started up with new volumes or | ||
* persistence, it will be assigned a new deployment id. This is different from the lifecycle of the | ||
* rest of the data layer which may be persisted across deployments. | ||
*/ | ||
private final UUID deploymentId; | ||
/** | ||
* deploymentEnvironment - the environment that airbyte is running in. | ||
*/ | ||
private final Configs.WorkerEnvironment deploymentEnv; | ||
|
||
public Deployment(final DeploymentMode deploymentMode, final UUID deploymentId, final WorkerEnvironment deploymentEnv) { | ||
Preconditions.checkNotNull(deploymentMode); | ||
Preconditions.checkNotNull(deploymentId); | ||
Preconditions.checkNotNull(deploymentEnv); | ||
|
||
this.deploymentMode = deploymentMode; | ||
this.deploymentId = deploymentId; | ||
this.deploymentEnv = deploymentEnv; | ||
} | ||
|
||
public DeploymentMode getDeploymentMode() { | ||
return deploymentMode; | ||
} | ||
|
||
public UUID getDeploymentId() { | ||
return deploymentId; | ||
} | ||
|
||
public WorkerEnvironment getDeploymentEnv() { | ||
return deploymentEnv; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,8 @@ | |
package io.airbyte.scheduler.app; | ||
|
||
import com.google.common.util.concurrent.ThreadFactoryBuilder; | ||
import io.airbyte.analytics.Deployment; | ||
import io.airbyte.analytics.Deployment.DeploymentMode; | ||
import io.airbyte.analytics.TrackingClientSingleton; | ||
import io.airbyte.commons.concurrency.GracefulShutdownHandler; | ||
import io.airbyte.commons.version.AirbyteVersion; | ||
|
@@ -239,13 +241,6 @@ public static void main(String[] args) throws IOException, InterruptedException | |
}); | ||
} | ||
|
||
TrackingClientSingleton.initialize( | ||
configs.getTrackingStrategy(), | ||
configs.getWorkerEnvironment(), | ||
configs.getAirbyteRole(), | ||
configs.getAirbyteVersion(), | ||
configRepository); | ||
|
||
Optional<String> airbyteDatabaseVersion = jobPersistence.getVersion(); | ||
int loopCount = 0; | ||
while ((airbyteDatabaseVersion.isEmpty() || !AirbyteVersion.isCompatible(configs.getAirbyteVersion(), airbyteDatabaseVersion.get())) | ||
|
@@ -261,6 +256,15 @@ public static void main(String[] args) throws IOException, InterruptedException | |
throw new IllegalStateException("Unable to retrieve Airbyte Version, aborting..."); | ||
} | ||
|
||
TrackingClientSingleton.initialize( | ||
configs.getTrackingStrategy(), | ||
// todo (cgardens) - we need to do the `#runServer` pattern here that we do in `ServerApp` so that | ||
// the deployment mode can be set by the cloud version. | ||
new Deployment(DeploymentMode.OSS, jobPersistence.getDeployment().orElseThrow(), configs.getWorkerEnvironment()), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jrhizor i did this heinous thing to get around the merge conflict. Obviously this is not how we want to set deployment mode. do you have thoughts on the right way to inject it? i'm still wrapping my head around the new factory. |
||
configs.getAirbyteRole(), | ||
configs.getAirbyteVersion(), | ||
configRepository); | ||
|
||
final WorkflowServiceStubs temporalService = TemporalUtils.createTemporalService(temporalHost); | ||
final TemporalClient temporalClient = TemporalClient.production(temporalHost, workspaceRoot); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opinion: I think it's useful to leave a comment here summarising how deploymetId -> workspace tie together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
instanceId
? I thinkinstance
has been the most common way to refer to the concept of adeployment
(and that's also reflected in our docs). Either is fine with me, just don't want to diverge naming. Feels like it's anAirbyteInstance
with aninstanceId
anddeploymentMode
/deploymentEnvironment
(vars that describe the deployment of the instance with that id).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed with @jrhizor offline. our goal here is to make sure the data model matches naming in the docs. we are keeping deployment, but i updated naming in docs to match deployment.