fix acceptance tests deps #4939
Conversation
| @@ -247,18 +247,8 @@ jobs: | |||
| # - name: Get Docker Space | |||
| # run: docker run --rm busybox df -h | |||
|
|
|||
| - name: Image Cleanup | |||
There was a problem hiding this comment.
these should not be needed anymore with the slimmer build.
There was a problem hiding this comment.
good catch. should we also remove the script? or keep just in case?
| # make sure these always run before pushing platform docker images | ||
| - name: Run End-to-End Acceptance Tests | ||
| if: success() && github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
we run k8s acceptance tests as part of PR. no reason we shouldn't do it for docker. also doing so would have cost the dependencies i missed in my PR.
There was a problem hiding this comment.
definitely. surprised this aren't running always.
| @@ -61,12 +61,6 @@ task acceptanceTests(type: Test) { | |||
| exceptionFormat "full" | |||
| } | |||
| mustRunAfter test | |||
|
|
|||
| dependsOn ':airbyte-integrations:connectors:source-postgres:airbyteDocker' | |||
There was a problem hiding this comment.
these should not have been here anymore. we use pinned versions of postgres source and destination
| dependsOn ':airbyte-integrations:connectors:source-postgres:airbyteDocker' | ||
| dependsOn ':airbyte-integrations:connectors:destination-postgres:airbyteDocker' | ||
| // for checkpointing tests | ||
| dependsOn ':airbyte-integrations:connectors:source-e2e-test:airbyteDocker' |
There was a problem hiding this comment.
switching to pinned versions of these makes these unnecessary.
| @@ -97,7 +97,7 @@ public void testAutomaticMigration() | |||
| logs.remove(keyToRemove); | |||
| } | |||
|
|
|||
| LOGGER.info(log); | |||
| LOGGER.info(log.trim()); | |||
There was a problem hiding this comment.
this is helm with extra whitespace that gets added.
What
How
Recommended reading order
x.javay.python