Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve get spec logging #4963

Merged
merged 1 commit into from
Jul 23, 2021
Merged

improve get spec logging #4963

merged 1 commit into from
Jul 23, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Jul 23, 2021

Should make it easier to debug "get spec" issues, especially since now it will output the message and stacktrace...

@jrhizor jrhizor requested a review from sherifnada July 23, 2021 22:02
@github-actions github-actions bot added the area/worker Related to worker label Jul 23, 2021
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add something too around when the worker starts

@jrhizor
Copy link
Contributor Author

jrhizor commented Jul 23, 2021

It's pretty clear when it's starting from the pod stuff. The exceptions we were seeing happened before it was able to launch the pod process, so I think it'll effectively be similar. I think the scoping will be more useful when we store/access logs based off of specific jobs or containers.

@jrhizor jrhizor merged commit fdc8ea1 into master Jul 23, 2021
@jrhizor jrhizor deleted the jrhizor/improve-get-spec-logging branch July 23, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants