Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Fix metadata import filter on deployment id #4977

Merged
merged 3 commits into from
Jul 26, 2021
Merged

🐞 Fix metadata import filter on deployment id #4977

merged 3 commits into from
Jul 26, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jul 26, 2021 •
edited
Loading

What

TODO

  • Unit test.

How

  • Filter out deployment_id only.

@tuliren tuliren requested a review from cgardens July 26, 2021 04:49
@github-actions github-actions bot added the area/platform issues related to the platform label Jul 26, 2021
@tuliren tuliren mentioned this pull request Jul 26, 2021
Merged
2 tasks
@tuliren tuliren requested a review from davinchia July 26, 2021 04:50
@tuliren tuliren mentioned this pull request Jul 26, 2021
Merged
3 tasks
@tuliren tuliren changed the title Fix metadata import filter on deployment id 🐞 Fix metadata import filter on deployment id Jul 26, 2021
davinchia
davinchia approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch!

I want to wait for @cgardens to confirm this.

cgardens
cgardens approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh. sorry about that. thank you for fixing it!

@tuliren tuliren merged commit 703bfe8 into master Jul 26, 2021
@tuliren tuliren deleted the liren/fix-metadata-import branch July 26, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@cgardens cgardens cgardens approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliren @cgardens @davinchia