Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Bamboo HR #5054

Merged
merged 7 commits into from
Aug 27, 2021

Conversation

haliva-firmbase
Copy link
Contributor

@haliva-firmbase haliva-firmbase commented Jul 28, 2021

What

New source for bamboo hr: https://documentation.bamboohr.com/docs
Solve this issue: #4931

Currently, it only supports Employees Directory API which is the only thing my company needs for now, in the future we might add additional APIs.

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@haliva-firmbase haliva-firmbase changed the title add bamboo hr 🎉 New Source: Bambbo HR Jul 28, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 28, 2021
@haliva-firmbase haliva-firmbase changed the title 🎉 New Source: Bambbo HR 🎉 New Source: Bamboo HR Jul 28, 2021
@marcosmarxm marcosmarxm requested a review from tuliren July 28, 2021 21:50
@marcosmarxm
Copy link
Member

@haliva-firmbase thanks for the contribution! There anything you need help?

@haliva-firmbase
Copy link
Contributor Author

@marcosmarxm @tuliren
I see you didn't CR my code yet, did I miss something?

@marcosmarxm
Copy link
Member

@haliva-firmbase oh! it's ready to review? can you change your PR from draft to ready?

@tuliren tuliren marked this pull request as ready for review August 11, 2021 17:32
@haliva-firmbase
Copy link
Contributor Author

@marcosmarxm I asked in slack what should I do next and you guys told me that will CR my code and let me know if I need to change anything. sorry for the confusion.

@tuliren
Copy link
Contributor

tuliren commented Aug 12, 2021

@haliva-firmbase, I am reviewing this PR. Would you mind giving me permission to your Airbyte fork? I'd like to push changes directly, such as resolving the conflicts. Otherwise, can you resolve the conflict in source_definitions.yaml yourself? Thank you.

@haliva-firmbase
Copy link
Contributor Author

@haliva-firmbase, I am reviewing this PR. Would you mind giving me permission to your Airbyte fork? I'd like to push changes directly, such as resolving the conflicts. Otherwise, can you resolve the conflict in source_definitions.yaml yourself? Thank you.

gave you permissions yesterday, you can also find me on slack (@orenhaliva) if you need anything else

@tuliren tuliren force-pushed the liren/bamboo-hr-pr-patch branch from 1608b4a to b2ef322 Compare August 27, 2021 10:46
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haliva-firmbase, this PR looks good. I have made some changes to fix the integration test. It should be ready to go now.

After merging this PR, I will create another PR to publish it.

Thank you for your contribution!

(Also don't forget to remove me from your repo.)

@tuliren tuliren merged commit 82f1638 into airbytehq:master Aug 27, 2021
@tuliren tuliren deleted the liren/bamboo-hr-pr-patch branch August 27, 2021 10:48
@tuliren tuliren mentioned this pull request Aug 27, 2021
17 tasks
@sherifnada sherifnada mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bamboo-hr connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants