Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable additionalProperties in spec.json for destinations #5125

Merged
merged 11 commits into from
Aug 1, 2021
Merged

Enable additionalProperties in spec.json for destinations #5125

merged 11 commits into from
Aug 1, 2021

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Jul 30, 2021 •
edited
Loading

What

Closes #5101

How

Easy solution is enable additionalProperties in all java connectors.

Recommended reading order

  • BigQuery
  • Snowflake
  • Oracle
  • Postgres
  • Mysql
  • MSSQL
  • Kafka
  • MeiliSearch

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 30, 2021
@jrhizor
Copy link
Contributor

jrhizor commented Jul 30, 2021

What's the motivation for this?

@cgardens
Copy link
Contributor

Our migration story around connector configurations is weak. https://airbytehq.slack.com/archives/C01MFR03D5W/p1627483462457500

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1083448180
✅ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/1083448180

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 20:13 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1083475775
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1083475775

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 20:23 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1083675921
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1083675921

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 21:51 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1083780986
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1083780986

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1083782300
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1083782300

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1083782456
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1083782456

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 22:43 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 22:43 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 22:43 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-kafka

🕑 connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1083857265
✅ connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1083857265

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-meilisearch

🕑 connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/1083858701
✅ connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/1083858701

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 23:23 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 23:23 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1087981395
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1087981395

@jrhizor jrhizor temporarily deployed to more-secrets August 1, 2021 19:28 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1088078549
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1088078549

@jrhizor jrhizor temporarily deployed to more-secrets August 1, 2021 20:33 Inactive
@marcosmarxm marcosmarxm merged commit 21e6d49 into master Aug 1, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/enable-additional-props-dest branch August 1, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery connectors/destination/meilisearch connectors/destination/snowflake connectors/destinations-api connectors/destinations-warehouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential Bug in migration leads to missing 'basic normalisation' schema message.
4 participants
@marcosmarxm @jrhizor @cgardens @karinakuz