Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (source-shopify) - Update the deprecation deadline for the change the change #51037 #51602

Merged

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jan 16, 2025

What

After the products graph ql stream deprecation change, the /products rest endpoint stopped serving the requests for the 2023-07, which the last one relies on.

This created the situation when the new release is available, the old data is not available but the sync keeps spinning the older version that tries to pull the old data continuously.

To solve this, we're pushing the UpgradeDeadline to the effective date of this PR created.

How

  • updated the metadata.yaml

User Impact

The customers affected should be automatically upgraded to the 2.6.1 accepting the breaking change.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 11:56pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 16, 2025
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 16, 2025
@bazarnov bazarnov marked this pull request as ready for review January 16, 2025 23:44
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 16, 2025 23:45
@bazarnov bazarnov changed the title fix: (source-shopify) - Update the deprecation deadline for the change [the change](https://github.com/airbytehq/airbyte/pull/51037) fix: (source-shopify) - Update the deprecation deadline for the change the change #51037 Jan 16, 2025
@bazarnov bazarnov enabled auto-merge (squash) January 16, 2025 23:50
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. And force-merging as discussed in the oncall thread here (internal link).

@aaronsteers aaronsteers disabled auto-merge January 16, 2025 23:50
@aaronsteers aaronsteers merged commit 787bfc9 into master Jan 16, 2025
22 of 27 checks passed
@aaronsteers aaronsteers deleted the baz/baz/source-shopify/update-deprecation-deadline branch January 16, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants