-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add java version to gradle #531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.gradle
Outdated
@@ -92,6 +92,11 @@ allprojects { | |||
tasks.withType(DockerBuildImage).all { task -> | |||
task.outputs.upToDateWhen { false } | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoudln't that be in the subprojects (// Java projects common configurations
) part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops yes
michel-tricot
approved these changes
Oct 9, 2020
sherifnada
approved these changes
Oct 9, 2020
davydov-d
added a commit
that referenced
this pull request
Sep 12, 2022
davydov-d
added a commit
that referenced
this pull request
Sep 12, 2022
davydov-d
added a commit
that referenced
this pull request
Sep 15, 2022
davydov-d
added a commit
that referenced
this pull request
Sep 15, 2022
davydov-d
added a commit
that referenced
this pull request
Sep 19, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* airbytehq#531 source s3: fix reading nested jsonl files * airbytehq#531 source s3: upd changelog * oncall airbytehq#531 source s3: fix sample file * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
This was referenced Oct 5, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* airbytehq#531 source s3: fix reading nested jsonl files * airbytehq#531 source s3: upd changelog * oncall airbytehq#531 source s3: fix sample file * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got easy to debug errors back when the fancy new case statements were added. Then I upgraded to Java 15 locally, which isn't supported by Gradle yet and got errors that were harder to debug.
I'm setting the version to 14 which matches the docker images we're using so we can ensure everyone is working on the same version.