Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add java version to gradle #531

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Oct 9, 2020

I got easy to debug errors back when the fancy new case statements were added. Then I upgraded to Java 15 locally, which isn't supported by Gradle yet and got errors that were harder to debug.

I'm setting the version to 14 which matches the docker images we're using so we can ensure everyone is working on the same version.

build.gradle Outdated
@@ -92,6 +92,11 @@ allprojects {
tasks.withType(DockerBuildImage).all { task ->
task.outputs.upToDateWhen { false }
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudln't that be in the subprojects (// Java projects common configurations) part?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yes

@jrhizor jrhizor merged commit ff53a7e into master Oct 9, 2020
@jrhizor jrhizor deleted the jrhizor/add-java-version-gradle branch October 9, 2020 16:28
davydov-d added a commit that referenced this pull request Sep 12, 2022
davydov-d added a commit that referenced this pull request Sep 12, 2022
davydov-d added a commit that referenced this pull request Sep 15, 2022
davydov-d added a commit that referenced this pull request Sep 19, 2022
* #531 source s3: fix reading nested jsonl files

* #531 source s3: upd changelog

* oncall #531 source s3: fix sample file

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* airbytehq#531 source s3: fix reading nested jsonl files

* airbytehq#531 source s3: upd changelog

* oncall airbytehq#531 source s3: fix sample file

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* airbytehq#531 source s3: fix reading nested jsonl files

* airbytehq#531 source s3: upd changelog

* oncall airbytehq#531 source s3: fix sample file

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants