Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix value extraction from JSON in source comprehensive test #5379

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Aug 12, 2021

Issue : #5380
In the PR #4457 we made changes to the class SourceComprehensiveTest, specifically on how we extract values from JSON record. This worked for Bigquery but broke the test for other sources like mssql, postgres, etc.

Portion of this was fixed in #5370

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@subodh1810 subodh1810 self-assigned this Aug 12, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 12, 2021
@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-mysql

🕑 source-mysql https://github.com/airbytehq/airbyte/actions/runs/1125311151
✅ source-mysql https://github.com/airbytehq/airbyte/actions/runs/1125311151

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-mssql

🕑 source-mssql https://github.com/airbytehq/airbyte/actions/runs/1125313047
✅ source-mssql https://github.com/airbytehq/airbyte/actions/runs/1125313047

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-snowflake

🕑 source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1125313654
✅ source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1125313654

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-bigquery

🕑 source-bigquery https://github.com/airbytehq/airbyte/actions/runs/1125313865
✅ source-bigquery https://github.com/airbytehq/airbyte/actions/runs/1125313865

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-cockroachdb

🕑 source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1125316668
✅ source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1125316668

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-db2

🕑 source-db2 https://github.com/airbytehq/airbyte/actions/runs/1125316869
✅ source-db2 https://github.com/airbytehq/airbyte/actions/runs/1125316869

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-oracle

🕑 source-oracle https://github.com/airbytehq/airbyte/actions/runs/1125318151
✅ source-oracle https://github.com/airbytehq/airbyte/actions/runs/1125318151

@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:22 Inactive
@subodh1810 subodh1810 merged commit 797445d into master Aug 16, 2021
@subodh1810 subodh1810 deleted the fix-source-comprehensive-test branch August 16, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants