Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source GitHub: handle negative backoff values #5696

Merged
merged 2 commits into from
Aug 27, 2021
Merged

🐛 Source GitHub: handle negative backoff values #5696

merged 2 commits into from
Aug 27, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Aug 27, 2021 •
edited
Loading

What

Closes #5694.

How

Describe the solution

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Aug 27, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 27, 2021
@Zirochkaa Zirochkaa changed the title Source GitHub: handle negative backoff values + update docs 🐛 Source GitHub: handle negative backoff values Aug 27, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 27, 2021 •
edited by github-actions bot
Loading

/test connector=source-github

🕑 source-github https://github.com/airbytehq/airbyte/actions/runs/1173719275
✅ source-github https://github.com/airbytehq/airbyte/actions/runs/1173719275

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 09:27 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 27, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1174581479
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1174581479

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 14:29 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 27, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1174620631
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1174620631

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 14:42 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Aug 27, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-github run-tests=false

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1174778126
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1174778126

@jrhizor jrhizor temporarily deployed to more-secrets August 27, 2021 15:34 Inactive
@Zirochkaa Zirochkaa merged commit 61f3963 into master Aug 27, 2021
@Zirochkaa Zirochkaa deleted the oleh/5694-github-negative-backoff branch August 27, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevhenii-ldv yevhenii-ldv yevhenii-ldv left review comments

@htrueman htrueman htrueman approved these changes

@sherifnada sherifnada sherifnada approved these changes

@avida avida Awaiting requested review from avida

@davinchia davinchia Awaiting requested review from davinchia

@tuliren tuliren Awaiting requested review from tuliren

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Connector successful sync but result in retry
6 participants
@Zirochkaa @sherifnada @htrueman @yevhenii-ldv @jrhizor @igrankova