Implement databricks connector as a copy destination #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
commented
Aug 31, 2021
| @@ -15,6 +15,14 @@ dependencies { | |||
| implementation project(':airbyte-integrations:bases:base-java') | |||
| implementation files(project(':airbyte-integrations:bases:base-java').airbyteDocker.outputs) | |||
| implementation project(':airbyte-integrations:connectors:destination-jdbc') | |||
| implementation project(':airbyte-integrations:connectors:destination-s3') | |||
There was a problem hiding this comment.
Let's depend on the s3 destination for now and DRY it later.
tuliren
changed the title
tuliren
changed the title
tuliren
commented
Aug 31, 2021
|
|
||
| @Override | ||
| public AirbyteConnectionStatus check(JsonNode config) { |
There was a problem hiding this comment.
The CopyDestination can check or create the SQL tables by calling the abstract method. So we only need to check the persistence in this implementation.
tuliren
commented
Aug 31, 2021
| * This implementation is similar to {@link io.airbyte.integrations.destination.jdbc.copy.s3.S3StreamCopier}. | ||
| * The difference is that this implementation creates Parquet staging files, instead of CSV ones. | ||
| */ | ||
| public class DatabricksStreamCopier implements StreamCopier { |
There was a problem hiding this comment.
We can focus on implementing the methods in this class to transfer the data from S3 to Databricks.
tuliren
commented
Aug 31, 2021
| @@ -36,7 +37,7 @@ | |||
| /** | |||
| * Writes a value to a staging file for the stream. | |||
| */ | |||
| void write(UUID id, String jsonDataString, Timestamp emittedAt) throws Exception; | |||
| void write(UUID id, AirbyteRecordMessage recordMessage) throws Exception; | |||
There was a problem hiding this comment.
This interface change is necessary to drop in the S3ParquetWriter directly for convenience.
tuliren
commented
Aug 31, 2021
| import io.airbyte.protocol.models.DestinationSyncMode; | ||
|
|
||
| public interface StreamCopierFactory<T> { | ||
|
|
||
| StreamCopier create(String configuredSchema, | ||
| T config, | ||
| String stagingFolder, | ||
| DestinationSyncMode syncMode, | ||
| AirbyteStream stream, | ||
| ConfiguredAirbyteStream configuredStream, |
There was a problem hiding this comment.
This interface change is necessary to reuse the S3Writer.
Phlair
approved these changes
Aug 31, 2021
|
@tuliren I'll merge this in and then work off it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JdbcDestinationtoCopyDestination.