-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Destination snowflake: split the snowflake insert query into multiple queries with a specific batch size #5783
🐛 Destination snowflake: split the snowflake insert query into multiple queries with a specific batch size #5783
Conversation
…es with a specific batch size
…4745-snowflake-destination-fix � Conflicts: � airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java
…es with a specific batch size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM, but:
- please make sure all check\tests passed before moving forward.
- Update main connector's documentation explicitly - add new param to configs list description, etc (where else may be needed)
/test connector=connectors/destination-snowflake
|
…4745-snowflake-destination-fix � Conflicts: � airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json � airbyte-config/init/src/main/resources/seed/destination_definitions.yaml � airbyte-integrations/connectors/destination-snowflake/Dockerfile � docs/integrations/destinations/snowflake.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the tests to use the batch logic. Currently I dont see any test which would test the new logic
airbyte-db/lib/src/main/java/io/airbyte/db/jdbc/DefaultJdbcDatabase.java
Outdated
Show resolved
Hide resolved
...tination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/SqlOperationsUtils.java
Outdated
Show resolved
Hide resolved
…4745-snowflake-destination-fix
…4745-snowflake-destination-fix � Conflicts: � airbyte-integrations/connectors/destination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/CopyConsumerFactory.java � airbyte-integrations/connectors/destination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/StreamCopier.java � airbyte-integrations/connectors/destination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/gcs/GcsStreamCopier.java � airbyte-integrations/connectors/destination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/s3/S3StreamCopier.java � airbyte-integrations/connectors/destination-s3/src/test-integration/java/io/airbyte/integrations/destination/s3/S3DestinationAcceptanceTest.java
...tion-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/s3/S3StreamCopier.java
Outdated
Show resolved
Hide resolved
...stination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/StreamCopier.java
Show resolved
Hide resolved
…4745-snowflake-destination-fix
…4745-snowflake-destination-fix
this remark is not relevant. I have reverted the changes in the specified files.
What
Sync succeeded but destination snowflake tables are empty
How
Split the snowflake insert query into multiple queries with a specific batch size. It is second part of fix this bug.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes