Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Slack: Fix sync operations hang forever issue #5830

Merged
merged 4 commits into from
Sep 3, 2021
Merged

🐛 Source Slack: Fix sync operations hang forever issue #5830

merged 4 commits into from
Sep 3, 2021

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Sep 3, 2021

What

#5816 - [Slack Connector] Sync operations hang forever

How

Add user-defined backoff

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 3, 2021
@lazebnyi lazebnyi added the area/documentation Improvements or additions to documentation label Sep 3, 2021
@lazebnyi lazebnyi linked an issue Sep 3, 2021 that may be closed by this pull request
[Slack Connector] Sync operations hang forever #5816
Closed
@lazebnyi @sherifnada
Update airbyte-integrations/connectors/source-slack/source_slack/sour…
7dd3b73 
…ce.py

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Sep 3, 2021
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1197244266
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1197244266

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 08:11 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1197304065
❌ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1197304065

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 08:32 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 3, 2021
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1197383040
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1197383040

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 09:00 Inactive
@lazebnyi lazebnyi merged commit 898e2c8 into master Sep 3, 2021
@lazebnyi lazebnyi deleted the lazebnyi/5816-sync-operation-issue branch September 3, 2021 09:19
@jrhizor jrhizor mentioned this pull request Sep 4, 2021
Merged
@SbiRomainLopez
Copy link

Hi guys,

I am still having the same issue :
airbyte 0.29.17 - alpha
slack connector 1.1.1
logs-54-0.txt

I am not able to sync Channel_Message

Let me know if I can provide more context

@marcosmarxm
Copy link
Member

@SbiRomainLopez can you open a new issue or comment in the #5816 original issue?

@lazebnyi lazebnyi mentioned this pull request Sep 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slack Connector] Sync operations hang forever
5 participants
@lazebnyi @SbiRomainLopez @marcosmarxm @sherifnada @jrhizor