Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source: Marketo #5863

Merged
merged 9 commits into from
Sep 23, 2021
Merged

🎉 New Source: Marketo #5863

merged 9 commits into from
Sep 23, 2021

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Sep 6, 2021 •
edited by antixar
Loading

What

#5240 - New Source: Marketo

How

Using CDK and custom methods implemented the connector logic for Marketo as a source for Airbyte.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 6, 2021
@lazebnyi lazebnyi linked an issue Sep 7, 2021 that may be closed by this pull request
New source: Marketo (airbyte native) #5240
Closed
antixar
antixar previously requested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your local test logs airbyte-integrations/connectors/source-marketo/acceptance_tests_logs

airbyte-integrations/connectors/source-marketo/Dockerfile Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Show resolved Hide resolved
bazarnov
bazarnov previously requested changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small corrections are needed.

airbyte-integrations/connectors/source-marketo/acceptance-test-config.yml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/build.gradle Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/schemas/activity_types.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/spec.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/utils.py Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py Outdated Show resolved Hide resolved
@lazebnyi lazebnyi marked this pull request as ready for review September 21, 2021 14:24
davinchia
davinchia approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

did you also manage to run the /test command? I don't see this on the PR.

airbyte-integrations/connectors/source-marketo/source_marketo/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/utils.py Show resolved Hide resolved
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265365630
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265365630

@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 10:09 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265405591
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265405591
🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265405591
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265405591

@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 10:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 10:38 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265482638
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265482638
🐛 https://gradle.com/s/g5mlyoamdlqko

@lazebnyi lazebnyi temporarily deployed to more-secrets September 23, 2021 10:48 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 10:49 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265691945
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265691945
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_marketo/__init__.py       2      0   100%
	 source_marketo/source.py       237    151    36%
	 source_marketo/utils.py         31      8    74%
	 ------------------------------------------------
	 TOTAL                          270    159    41%

@lazebnyi lazebnyi temporarily deployed to more-secrets September 23, 2021 11:58 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 12:00 Inactive
@lazebnyi lazebnyi dismissed stale reviews from bazarnov and antixar September 23, 2021 12:43

Already approved by airbyte

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265848852
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265848852
🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265848852
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1265848852

@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 12:46 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 12:51 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1266187684
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1266187684

@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 14:20 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets September 23, 2021 14:42 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Sep 23, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1266334840
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1266334840

@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 14:59 Inactive
@lazebnyi lazebnyi merged commit 26c9546 into master Sep 23, 2021
@lazebnyi lazebnyi deleted the lazebnyi/5240-marketo branch September 23, 2021 15:51
@jrhizor jrhizor mentioned this pull request Sep 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@bazarnov bazarnov bazarnov left review comments

@antixar antixar antixar left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New source: Marketo (airbyte native)
5 participants
@lazebnyi @davinchia @antixar @bazarnov @jrhizor