-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new source: kafka #5906
new source: kafka #5906
Conversation
@heade could you please include some more context for liren to be able to review the code? For example, links to any design docs, the reading order, any interesting implementation details? Also could you maximize the appropriate checklist section i.e: "New connector"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the contribution.
A few docs and links are missing. But I can do that in a follow up PR.
|
||
#### Integration Tests | ||
TODO: _how can a user run integration tests?_ | ||
_this section is currently under construction -- please reach out to us on Slack for help with setting up Airbyte's standard test suite_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This TODO
s should either be resolved or removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heade, sorry that I did not know you are from the GL team. Can you create a follow-up PR to complete the remaining tasks and publish this connector?
- A follow up PR for #5906. - Register the Kafka source in the source index. - We temporarily categorize this connector as `database` for convenience. However, this may change in the future.
- A follow up PR for airbytehq#5906. - Register the Kafka source in the source index. - We temporarily categorize this connector as `database` for convenience. However, this may change in the future.
What
Source Kafka: #2655
How
Implemented the connector logic for Kafka as a source for Airbyte.
MVP scope:
-Full refresh.
-Possibility to configure topic offset per partition.
-SASL auth
-Within batch processing with one consumer
Phase 2 scope:
-tls auth
-Incremental sync
2 types of subscriptions are implemented: topic-pattern and topic-partitions. To build streams in the first case, all available topics for this consumer are taken, and then filtered using a pattern: link
Recommended reading order
spec.json
KafkaSourceConfig.java
KafkaSource.java
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes