-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: custom webpack build #6006
Conversation
Awesome work @isalikov and congrats on your first PR tho the airbyte! First of all, let's postpone this PR a bit and wait when #5656 is merged. Once you revert those changes for prettier ( if we have some - let's better address them as separate PR ) and I will do 1 more review round as it will be much easier. |
"removeComments": true, | ||
"preserveConstEnums": true, | ||
"sourceMap": true, | ||
"noUnusedParameters": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we are not going to make our code style less strict. Let's not change our ts code style and keep it as strict as possible.
What
react-scripts
withcreate-react-add
dependencies was replaced with customwebpack
setup