WIP: custom webpack build #6006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work @isalikov and congrats on your first PR tho the airbyte! First of all, let's postpone this PR a bit and wait when #5656 is merged. Once you revert those changes for prettier ( if we have some - let's better address them as separate PR ) and I will do 1 more review round as it will be much easier. |
jamakase
reviewed
Sep 13, 2021
| "removeComments": true, | ||
| "preserveConstEnums": true, | ||
| "sourceMap": true, | ||
| "noUnusedParameters": true, |
There was a problem hiding this comment.
I suppose we are not going to make our code style less strict. Let's not change our ts code style and keep it as strict as possible.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
react-scriptswithcreate-react-adddependencies was replaced with customwebpacksetup