-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix Snowflake destination normalization to accept any date-time format. #6052
Conversation
/test connector=bases/base-normalization
|
@yaroslav-dudar your build issue should be fixed once you merge latest master |
/test connector=bases/base-normalization
|
/test connector=bases/base-normalization
|
/test connector=bases/base-normalization
|
/test connector=bases/base-normalization
|
/publish connector=bases/base-normalization
|
@yaroslav-dudar I think the failure is in the test itself. Have you verified they are passing locally? |
@sherifnada but it's passed here #6052 (comment) and I see errors like this
|
/test connector=bases/base-normalization
|
/publish connector=bases/base-normalization
|
Yes, if you see these errors:
Then, for some reason, when you publish, maybe the destination image (dev versions) are not available when publishing but they are correctly built/used during the test? |
it's weird because |
@ChristopheDuong https://github.com/airbytehq/airbyte/runs/3672622870?check_suite_focus=true#step:10:4645 - base-normalization:customIntegrationTests |
maybe I need to change |
Oh, I remember I did struggle the same as you in the past... here, see this PR: https://github.com/airbytehq/airbyte/pull/4910/files#r677136914 |
/publish connector=bases/base-normalization
|
@ChristopheDuong please check, is it ok for you 5b3bd3a ? another point, seems like connector was published but I got error in the end https://github.com/airbytehq/airbyte/runs/3677499341?check_suite_focus=true#step:10:12179 is it possible that my changes are the reason of that issue?? |
Yes, it seemed to have publish fine! Can you check that published docker image version has your change in it? (not in conflict from a publish from another PR?) |
The error seemed to come from:
which is from #5994 Normalization does not have "spec" commands as usual connectors do... so it seems normal and the publish should probably ignore writing to spec cache for normalization images in |
verified, |
@ChristopheDuong please notify me if I can merge it |
Yes, if it's published, you're all good to merge, go ahead |
What
Fixed snowflake destination support for date-time format #5713
How
Describe the solution
Recommended reading order
base-normalization/normalization/transform_catalog/stream_processor.py
base-normalization/dbt-project-template/macros/cross_db_utils/datatypes.sql
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes