Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 🎉 Source Shopify: added the pre_tax_price to orders/line_items schema, update stream_slices logic #6056

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Sep 14, 2021

What

Self Initiated Fix.

How

  • Added the property of the orders/line_items == pre_tax_price available only for the Shopify Plus users
  • Migrated reading records of parent stream in OrderSubstream to stream_slices()
  • Renamed OrderSubstream to ChildSubstream
  • Unified ChildSubstream for use within other stream classes for future development.
  • Edited unit_tests accordingly

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@bazarnov bazarnov self-assigned this Sep 14, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 14, 2021
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 14, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1234034561
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1234034561

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 14, 2021
@bazarnov bazarnov requested review from midavadim and removed request for sherifnada September 14, 2021 14:37
@bazarnov bazarnov changed the title 📝 Source Shopify: added the pre_tax_price to orders/line_items schema 📝 🎉 Source Shopify: added the pre_tax_price to orders/line_items schema Sep 14, 2021
@bazarnov bazarnov changed the title 📝 🎉 Source Shopify: added the pre_tax_price to orders/line_items schema 📝 🎉 Source Shopify: added the pre_tax_price to orders/line_items schema Sep 14, 2021
@bazarnov bazarnov changed the title 📝 🎉 Source Shopify: added the pre_tax_price to orders/line_items schema 📝 🎉 Source Shopify: added the pre_tax_price to orders/line_items schema, update stream_slices logic Sep 18, 2021
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 21, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1257611080
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1257611080
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/source.py        196    196     0%
	 -------------------------------------------------Coverage.py warning: No data was collected. (no-data-collected)
	 source_shopify/transform.py      53     53     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           308    308     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/source.py        196     80    59%
	 source_shopify/transform.py      53      0   100%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           308     86    72%

@bazarnov bazarnov temporarily deployed to more-secrets September 21, 2021 12:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 21, 2021 12:40 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 21, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1257680684
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1257680684

@jrhizor jrhizor temporarily deployed to more-secrets September 21, 2021 13:01 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets September 21, 2021 13:28 Inactive
@bazarnov bazarnov merged commit 023a9ba into master Sep 21, 2021
@bazarnov bazarnov deleted the bazarnov/shopify-pre-tax-price branch September 21, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants